New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projectexportfixes #3525

Closed
wants to merge 25 commits into
base: stable-1.2
from

Conversation

Projects
None yet
7 participants
@zonkmachine
Member

zonkmachine commented May 1, 2017

If writing over an existing file on export you are prompted twice. See comment here:
#3516 (comment)

@Umcaruje I had this fix lying around already but hadn't tested it properly. It looks like a fix but it should

lukas-w and others added some commits Mar 26, 2017

Use Qt's Resource System (2nd approach) (#1891)
* Remove bin2res, use Qt's resource system
* Use QDir search paths and QImageReader in getIconPixmap
* Don't include "embed.cpp" in plugins
* getIconPixmap: Use QPixmapCache, use QPixmap::fromImageReader
* Require CMake 2.8.9

* Fix ReverbSC embed usage
Always highlight the beats in PianoRoll and AutomationEditor using on…
…ly time signature (#3458)

* Duration of the beat is defined by the denominator of the time signature
and it does not depend on whether or not you use triplets.

* Fortmatting fixed.
Added support for official wine-devel and wine-staging packages. (#3278)
* Added support for wine-devel packages.

* Added support for wine-staging packages.

* Staging extra flags.

* Dynamic Wine branch detection (stable, devel, staging).

* Using STRING() to correct WINE_INCLUDE_DIR and WINE_LIBRARY.

* Don't override CMAKE_PREFIX_PATH.

* REPLACE outputs new variables.

* Renamed variables.
Revert "Update README.md"
Accidental GitHub commmit
This reverts commit 5f1550d.
Revert "Update README.md"
Accidental github commit
This reverts commit bd1fb1a.
Added Buzzer Beater to demos (#3482)
Add 2017 kicker competition winner to demo projects.
Simpler SF2 Player file dialog. Copied from GIG Player. Opens correct…
… SF2 plugin directory when running LMMS from build directory without install. (#3502)
Fixed #3182. Always using master channel for preset previews. (#3503)
* Fixed #3182. Always using master channel for preset previews.
@tresf

This comment has been minimized.

Member

tresf commented on .travis/osx..script.sh in 7844b3e Apr 18, 2017

@zapashcanon just caught this.... This should switch to the new syntax as well.

@tresf

This comment has been minimized.

Member

tresf commented on cmake/apple/install_apple.sh.in in 7844b3e Apr 18, 2017

@zapashcanon just caught this.... This should switch to the new syntax as well.

@tresf

This comment has been minimized.

Member

tresf commented on cmake/apple/install_apple.sh.in in 7844b3e Apr 18, 2017

@zapashcanon just caught this.... This should switch to the new syntax as well.

This comment has been minimized.

Member

tresf replied Apr 18, 2017

Also, a non-zero $? fails on set -e. This breaks the entire script.

@zonkmachine zonkmachine closed this May 1, 2017

@zonkmachine

This comment has been minimized.

Member

zonkmachine commented May 1, 2017

Borked this PR. You can't reopen a PR after force pushing to a closed one...
New one here: #3526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment