New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export - double dialog windows on writing over existing file #3526

Merged
merged 2 commits into from May 30, 2017

Conversation

Projects
None yet
5 participants
@zonkmachine
Member

zonkmachine commented May 1, 2017

If writing over an existing file on export you are prompted twice. See comment here:
#3516 (comment)
Issue introduced here: #2230

@Umcaruje I had this fix lying around already but hadn't tested it properly. It looks like a fix but needs more testing.

@zonkmachine zonkmachine requested a review from Umcaruje May 1, 2017

@zonkmachine zonkmachine added this to the 1.2.0 milestone May 1, 2017

@zonkmachine zonkmachine referenced this pull request May 1, 2017

Closed

Projectexportfixes #3525

@Pyrif

This comment has been minimized.

Show comment
Hide comment
@Pyrif

Pyrif May 2, 2017

Export showed 2 overwrite dialogs before checkout. After checkout, 1 overwrite dialog is shown. Pull request works as expected.

Pyrif commented May 2, 2017

Export showed 2 overwrite dialogs before checkout. After checkout, 1 overwrite dialog is shown. Pull request works as expected.

Show outdated Hide outdated src/core/Song.cpp Outdated
@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine May 2, 2017

Member

By defaul it's case insensitive by default which can cause issues on Mac and Windows, since they're both case-insensitive (yes, Mac is too!)

Fixed... I think.

This will remove all instances of e.g. .wav, so there are some edge cases where my.wav.file.wav might get snagged, no?

Yes. Will think. Think not easy. Sad.

Member

zonkmachine commented May 2, 2017

By defaul it's case insensitive by default which can cause issues on Mac and Windows, since they're both case-insensitive (yes, Mac is too!)

Fixed... I think.

This will remove all instances of e.g. .wav, so there are some edge cases where my.wav.file.wav might get snagged, no?

Yes. Will think. Think not easy. Sad.

@Umcaruje

Tested this out, can confirm it fixes the issue 👍

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje May 21, 2017

Member

@zonkmachine can we merge or do you have something to add to this PR?

Member

Umcaruje commented May 21, 2017

@zonkmachine can we merge or do you have something to add to this PR?

@qnebra

This comment has been minimized.

Show comment
Hide comment
@qnebra

qnebra May 27, 2017

Tested locally, fixed double export dialog issue for me.

qnebra commented May 27, 2017

Tested locally, fixed double export dialog issue for me.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine May 28, 2017

Member

@zonkmachine can we merge or do you have something to add to this PR?

I'm not near my build machine so I can't work on this right now but I'm happy with a merge. @tresf had made some points above that I also can't test or do anything about right now.

Member

zonkmachine commented May 28, 2017

@zonkmachine can we merge or do you have something to add to this PR?

I'm not near my build machine so I can't work on this right now but I'm happy with a merge. @tresf had made some points above that I also can't test or do anything about right now.

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje May 30, 2017

Member

Ok no objections to a merge for 3 days, merging this. If there are any issues, they can be opened on the tracker.

Member

Umcaruje commented May 30, 2017

Ok no objections to a merge for 3 days, merging this. If there are any issues, they can be opened on the tracker.

@Umcaruje Umcaruje merged commit 9bdc011 into LMMS:stable-1.2 May 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zonkmachine zonkmachine deleted the zonkmachine:exportfixstable branch May 30, 2017

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine May 30, 2017

Member

If there are any issues, they can be opened on the tracker.

Cool! I'll test this later on and there are still questions from @tresf unanswered. Will get to that.

Member

zonkmachine commented May 30, 2017

If there are any issues, they can be opened on the tracker.

Cool! I'll test this later on and there are still questions from @tresf unanswered. Will get to that.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf May 30, 2017

Member

There are still some logical problems. Linux can have .foo and .FOO side-by-side (valid albeit confusing) whereas Windows and MacOS cannot, so that logic is a bit presumptuous and these edge-cases will be very confusing in the very rare event they occur.

There's also the double-extension problem, where .remove() makes no guarantee that the extension is at the end of the file. Again, very rare edge-case but when it happen to someone it won't be obvious. For example ocean.waves.wav would become oceanes.wav. :)

Member

tresf commented May 30, 2017

There are still some logical problems. Linux can have .foo and .FOO side-by-side (valid albeit confusing) whereas Windows and MacOS cannot, so that logic is a bit presumptuous and these edge-cases will be very confusing in the very rare event they occur.

There's also the double-extension problem, where .remove() makes no guarantee that the extension is at the end of the file. Again, very rare edge-case but when it happen to someone it won't be obvious. For example ocean.waves.wav would become oceanes.wav. :)

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Fix export - double dialog windows on writing over existing file (#3526)
* Fix export - double dialog windows on writing over existing file

* Case sensitivity

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Fix export - double dialog windows on writing over existing file (#3526)
* Fix export - double dialog windows on writing over existing file

* Case sensitivity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment