New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LFO controller now has correct frequency with multiple connections. #3535

Merged
merged 1 commit into from May 7, 2017

Conversation

Projects
None yet
6 participants
@curlymorphic
Contributor

curlymorphic commented May 7, 2017

The LFO controller was playing at incorrect frequencies when their were multiple connections.

This was caused by the buffer counters not being correctly set.

m_bufferLastUpdated is now correctly set to the current frame upon updating
the buffer.

fixes #3064

@Umcaruje
Can you test this for me please, as you confirmed you could reproduce the bug in the original report

LFO controller now has correct frequency with multiple connections.
m_bufferLastUpdated is now correctly set to the current frame upon updating
the buffer.
@karmux

This comment has been minimized.

Show comment
Hide comment
@karmux

karmux May 7, 2017

Contributor

@curlymorphic good find! I tested this and I can confirm that in this PR #3064 is fixed 👍

Contributor

karmux commented May 7, 2017

@curlymorphic good find! I tested this and I can confirm that in this PR #3064 is fixed 👍

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine May 7, 2017

Member

Great! #3064 and also another bug report in the forums is fixed here. 👍

Member

zonkmachine commented May 7, 2017

Great! #3064 and also another bug report in the forums is fixed here. 👍

@Jousboxx

This comment has been minimized.

Show comment
Hide comment
@Jousboxx

Jousboxx May 7, 2017

Contributor

Seems to work!

Windows build for anyone who is interested
https://drive.google.com/open?id=0B8dZ3IVOKKA6SWRWMXlwdXRVaXM

Contributor

Jousboxx commented May 7, 2017

Seems to work!

Windows build for anyone who is interested
https://drive.google.com/open?id=0B8dZ3IVOKKA6SWRWMXlwdXRVaXM

@tresf tresf merged commit ff4ffd1 into LMMS:stable-1.2 May 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje May 7, 2017

Member

👍

Member

Umcaruje commented May 7, 2017

👍

@curlymorphic curlymorphic deleted the curlymorphic:lfo branch May 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment