Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LFO controller now has correct frequency with multiple connections. #3535

Merged
merged 1 commit into from May 7, 2017

Conversation

@curlymorphic
Copy link
Contributor

@curlymorphic curlymorphic commented May 7, 2017

The LFO controller was playing at incorrect frequencies when their were multiple connections.

This was caused by the buffer counters not being correctly set.

m_bufferLastUpdated is now correctly set to the current frame upon updating
the buffer.

fixes #3064

@Umcaruje
Can you test this for me please, as you confirmed you could reproduce the bug in the original report

m_bufferLastUpdated is now correctly set to the current frame upon updating
the buffer.
@karmux
Copy link
Contributor

@karmux karmux commented May 7, 2017

@curlymorphic good find! I tested this and I can confirm that in this PR #3064 is fixed 👍

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented May 7, 2017

Great! #3064 and also another bug report in the forums is fixed here. 👍

@Jousboxx
Copy link
Contributor

@Jousboxx Jousboxx commented May 7, 2017

Seems to work!

Windows build for anyone who is interested
https://drive.google.com/open?id=0B8dZ3IVOKKA6SWRWMXlwdXRVaXM

@tresf tresf merged commit ff4ffd1 into LMMS:stable-1.2 May 7, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Umcaruje
Copy link
Member

@Umcaruje Umcaruje commented May 7, 2017

👍

@curlymorphic curlymorphic deleted the curlymorphic:lfo branch May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants
You can’t perform that action at this time.