LFO controller now has correct frequency with multiple connections. #3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m_bufferLastUpdated is now correctly set to the current frame upon updating the buffer.
|
@curlymorphic good find! I tested this and I can confirm that in this PR #3064 is fixed 👍 |
|
Great! #3064 and also another bug report in the forums is fixed here. 👍 |
|
Seems to work! Windows build for anyone who is interested |
|
👍 |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
LFO controller now has correct frequency with multiple connections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LFO controller was playing at incorrect frequencies when their were multiple connections.
This was caused by the buffer counters not being correctly set.
m_bufferLastUpdated is now correctly set to the current frame upon updating
the buffer.
fixes #3064
@Umcaruje
Can you test this for me please, as you confirmed you could reproduce the bug in the original report