Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
First, what happens if the VST does not exist at the given path? Does it know to fallback to the VST directory?
Second, have you considered consolidating this into the
Reason being... we already have areas where the existing constructor could simplify the code since the existing constructor supports
@tresf Good that you asked that. It didn't default to configured VST plugin directory if the VST plugin did not exist at the given path. SF2 and GIG players seemed to default to plugins directory defined in config. I fixed this in similar way to GIG Player.
I was thinking about some general helper functionality for all these instrument plugins but that would be safer to implement for next version after 1.2 I think.
The only concern I have is with the way we display the error message with this PR.
Previously, if a vst was in