fix export project for sampletracks with vst effects on it #3571

Merged
merged 2 commits into from May 29, 2017

Conversation

Projects
None yet
3 participants
@BaraMGB
Contributor

BaraMGB commented May 21, 2017

fixes #3511

@Umcaruje

Tested, this fixes the issue 👍

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB May 22, 2017

Contributor

Okay, but now we don't need this anymore:

connect( gui->songEditor(), SIGNAL( playTriggered() ), this, SLOT( playbackPositionChanged() ) );

I'll remove that.

Contributor

BaraMGB commented May 22, 2017

Okay, but now we don't need this anymore:

connect( gui->songEditor(), SIGNAL( playTriggered() ), this, SLOT( playbackPositionChanged() ) );

I'll remove that.

@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB May 23, 2017

Contributor

I guess I merge this tomorrow.

Contributor

BaraMGB commented May 23, 2017

I guess I merge this tomorrow.

@Spekular

This comment has been minimized.

Show comment
Hide comment
@Spekular

Spekular May 29, 2017

Contributor

@BaraMGB did something come up or should this be merged?

I guess I merge this tomorrow.

Contributor

Spekular commented May 29, 2017

@BaraMGB did something come up or should this be merged?

I guess I merge this tomorrow.

@BaraMGB BaraMGB merged commit 1eef218 into LMMS:stable-1.2 May 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BaraMGB

This comment has been minimized.

Show comment
Hide comment
@BaraMGB

BaraMGB May 29, 2017

Contributor

@Spekular 👍

Contributor

BaraMGB commented May 29, 2017

@Spekular 👍

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

fix export project for sampletracks with vst effects on it (#3571)
* fix export project for sampletracks with vst effects on it

* removed playTriggered Signal

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

fix export project for sampletracks with vst effects on it (#3571)
* fix export project for sampletracks with vst effects on it

* removed playTriggered Signal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment