Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix export project for sampletracks with vst effects on it #3571

Merged
merged 2 commits into from May 29, 2017

Conversation

@BaraMGB
Copy link
Contributor

BaraMGB commented May 21, 2017

fixes #3511

Copy link
Member

Umcaruje left a comment

Tested, this fixes the issue 👍

@BaraMGB
Copy link
Contributor Author

BaraMGB commented May 22, 2017

Okay, but now we don't need this anymore:

connect( gui->songEditor(), SIGNAL( playTriggered() ), this, SLOT( playbackPositionChanged() ) );

I'll remove that.

@BaraMGB
Copy link
Contributor Author

BaraMGB commented May 23, 2017

I guess I merge this tomorrow.

@Spekular
Copy link
Contributor

Spekular commented May 29, 2017

@BaraMGB did something come up or should this be merged?

I guess I merge this tomorrow.

@BaraMGB BaraMGB merged commit 1eef218 into LMMS:stable-1.2 May 29, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BaraMGB
Copy link
Contributor Author

BaraMGB commented May 29, 2017

@Spekular 👍

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
* fix export project for sampletracks with vst effects on it

* removed playTriggered Signal
PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
* fix export project for sampletracks with vst effects on it

* removed playTriggered Signal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.