Skip to content

fix export project for sampletracks with vst effects on it#3571

Merged
BaraMGB merged 2 commits into
LMMS:stable-1.2from
BaraMGB:sampletrackexportvst
May 29, 2017
Merged

fix export project for sampletracks with vst effects on it#3571
BaraMGB merged 2 commits into
LMMS:stable-1.2from
BaraMGB:sampletrackexportvst

Conversation

@BaraMGB
Copy link
Copy Markdown
Contributor

@BaraMGB BaraMGB commented May 21, 2017

fixes #3511

Copy link
Copy Markdown
Member

@Umcaruje Umcaruje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, this fixes the issue 👍

@BaraMGB
Copy link
Copy Markdown
Contributor Author

BaraMGB commented May 22, 2017

Okay, but now we don't need this anymore:

connect( gui->songEditor(), SIGNAL( playTriggered() ), this, SLOT( playbackPositionChanged() ) );

I'll remove that.

@BaraMGB
Copy link
Copy Markdown
Contributor Author

BaraMGB commented May 23, 2017

I guess I merge this tomorrow.

@Spekular
Copy link
Copy Markdown
Member

@BaraMGB did something come up or should this be merged?

I guess I merge this tomorrow.

@BaraMGB BaraMGB merged commit 1eef218 into LMMS:stable-1.2 May 29, 2017
@BaraMGB
Copy link
Copy Markdown
Contributor Author

BaraMGB commented May 29, 2017

@Spekular 👍

PhysSong pushed a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
* fix export project for sampletracks with vst effects on it

* removed playTriggered Signal
PhysSong pushed a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
* fix export project for sampletracks with vst effects on it

* removed playTriggered Signal
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
* fix export project for sampletracks with vst effects on it

* removed playTriggered Signal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sample Tracks won't export if they have VST effects on them

3 participants