Proper Case Renames #3573
Merged
Proper Case Renames #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied Proper Case to the Title Bar and updated the message that gets typed into editor to.... "Enter Project Notes Here" Although this should probably be removed entirely, because I think most know what they are supposed to do with a word processor, especially one that is called "Project Notes" :)
|
I'm sorry but is this really the case we want? Sentence case would make a lot more sense to me here rather than capitalizing each word. |
|
|
|
Thanks for the feedback. I examined various parts of the interface and we use "Title Case" for window titles and sections and "Sentence case" for buttons and sentences. @liushuyu FYI, this will affect translations. |
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 8, 2017
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 8, 2017
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@liushuyu
Please merge my "Patch 1" changes if this is done correctly.
@tresf
As per our discussion a while back, you mention that in order to make a batch of changes, I should select the "Patch 1" in my own profile, make all the changes to it, and then make one pull request for any changes in that batch (Patch 1).
Sorry to bother you guys, but can someone just check that I have done this correctly.
I think I have a friend that will be joining the site and will be helping with minor updates like these.
I will show him how to do this exactly the way that I did to my "Patch 1", so I just want to make sure that I am doing this right so that I will not be teaching him incorrectly.
Thank You