New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper Case Renames #3573

Merged
merged 7 commits into from Jun 2, 2017

Conversation

Projects
None yet
4 participants
@miketurn
Contributor

miketurn commented May 24, 2017

@liushuyu
Please merge my "Patch 1" changes if this is done correctly.

@tresf
As per our discussion a while back, you mention that in order to make a batch of changes, I should select the "Patch 1" in my own profile, make all the changes to it, and then make one pull request for any changes in that batch (Patch 1).

Sorry to bother you guys, but can someone just check that I have done this correctly.
I think I have a friend that will be joining the site and will be helping with minor updates like these.
I will show him how to do this exactly the way that I did to my "Patch 1", so I just want to make sure that I am doing this right so that I will not be teaching him incorrectly.

Thank You

miketurn added some commits Jan 12, 2017

Update ProjectNotes.cpp
Applied Proper Case to the Title Bar

and updated the message that gets typed into editor to....
"Enter Project Notes Here"

Although this should probably be removed entirely, because I think most know what they are supposed to do with a word processor, especially one that is called "Project Notes" :)

@miketurn miketurn changed the title from Patch 1 to Proper Case Renames May 24, 2017

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje May 30, 2017

Member

I'm sorry but is this really the case we want?

Sentence case would make a lot more sense to me here rather than capitalizing each word.

Member

Umcaruje commented May 30, 2017

I'm sorry but is this really the case we want?

Sentence case would make a lot more sense to me here rather than capitalizing each word.

@karmux

This comment has been minimized.

Show comment
Hide comment
@karmux

karmux May 31, 2017

Contributor

Instrument Plugins and Project Notes makes them consistent with other window titles but for other changes I agree with @Umcaruje. They are more like sentences not titles.

Contributor

karmux commented May 31, 2017

Instrument Plugins and Project Notes makes them consistent with other window titles but for other changes I agree with @Umcaruje. They are more like sentences not titles.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Jun 2, 2017

Member

Thanks for the feedback. I examined various parts of the interface and we use "Title Case" for window titles and sections and "Sentence case" for buttons and sentences.

@liushuyu FYI, this will affect translations.

Member

tresf commented Jun 2, 2017

Thanks for the feedback. I examined various parts of the interface and we use "Title Case" for window titles and sections and "Sentence case" for buttons and sentences.

@liushuyu FYI, this will affect translations.

@tresf tresf added this to the 1.2.0 milestone Jun 2, 2017

@tresf tresf merged commit 1f66f62 into LMMS:stable-1.2 Jun 2, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Jun 2, 2017

Member

Commit history is strange for this one. GitHub split this into 4b92651 and 1f66f62. Not sure why, just an FYI.

Member

tresf commented Jun 2, 2017

Commit history is strange for this one. GitHub split this into 4b92651 and 1f66f62. Not sure why, just an FYI.

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment