Fix loop condition in project rendering (#3105, #2030) #3576

Merged
merged 2 commits into from May 29, 2017

Conversation

Projects
None yet
4 participants
@PhysSong
Member

PhysSong commented May 26, 2017

Fix loop condition in ProjectRenderer::run().
It fixes #2030 clearly.
@DeRobyJ Could you test this for #3105?

Based on #3105 (comment)
(The idea from @softrabbit)

@qnebra

This comment has been minimized.

Show comment
Hide comment
@qnebra

qnebra May 27, 2017

Numerator automation fixed, but I don't know nothing about second issue.

qnebra commented May 27, 2017

Numerator automation fixed, but I don't know nothing about second issue.

@Umcaruje

Tested this with all 3 export modes and it works perfectly 👍

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine May 29, 2017

Member

Tested this with all 3 export modes and it works perfectly 👍

Then I suggest merging this. 🚜

Member

zonkmachine commented May 29, 2017

Tested this with all 3 export modes and it works perfectly 👍

Then I suggest merging this. 🚜

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje May 29, 2017

Member

👍

Member

Umcaruje commented May 29, 2017

👍

@Umcaruje Umcaruje merged commit 4ff091f into LMMS:stable-1.2 May 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje May 29, 2017

Member

Thank you for your contribution @PhysSong !

Member

Umcaruje commented May 29, 2017

Thank you for your contribution @PhysSong !

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Fix loop condition in project rendering (#3105, #2030) (#3576)
* Change loop condition in ProjectRenderer::run()

* Remove Song::isExportDone()

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Fix loop condition in project rendering (#3105, #2030) (#3576)
* Change loop condition in ProjectRenderer::run()

* Remove Song::isExportDone()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment