Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loop condition in project rendering (#3105, #2030) #3576

Merged
merged 2 commits into from May 29, 2017

Conversation

@PhysSong
Copy link
Member

PhysSong commented May 26, 2017

Fix loop condition in ProjectRenderer::run().
It fixes #2030 clearly.
@DeRobyJ Could you test this for #3105?

Based on #3105 (comment)
(The idea from @softrabbit)

@qnebra
Copy link

qnebra commented May 27, 2017

Numerator automation fixed, but I don't know nothing about second issue.

Copy link
Member

Umcaruje left a comment

Tested this with all 3 export modes and it works perfectly 👍

@zonkmachine
Copy link
Member

zonkmachine commented May 29, 2017

Tested this with all 3 export modes and it works perfectly 👍

Then I suggest merging this. 🚜

@Umcaruje
Copy link
Member

Umcaruje commented May 29, 2017

👍

@Umcaruje Umcaruje merged commit 4ff091f into LMMS:stable-1.2 May 29, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Umcaruje
Copy link
Member

Umcaruje commented May 29, 2017

Thank you for your contribution @PhysSong !

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
…3576)

* Change loop condition in ProjectRenderer::run()

* Remove Song::isExportDone()
PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
…3576)

* Change loop condition in ProjectRenderer::run()

* Remove Song::isExportDone()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.