Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes position marker height on startup #3587

Merged
merged 2 commits into from Jun 2, 2017
Merged

Conversation

@BaraMGB
Copy link
Contributor

@BaraMGB BaraMGB commented May 29, 2017

fixes #3581

@@ -697,6 +705,7 @@ SongEditorWindow::SongEditorWindow(Song* song) :
zoomToolBar->addWidget( m_zoomingComboBox );

connect(song, SIGNAL(projectLoaded()), this, SLOT(adjustUiAfterProjectLoad()));
connect( this, SIGNAL(resized() ), m_editor, SLOT( updatePositionLine() ) );

This comment has been minimized.

@Umcaruje

Umcaruje May 30, 2017
Member

please correct the formatting on this, either have or have not spaces in the parenthesis, but this mix-and-match looks inconsistent.

@Umcaruje
Copy link
Member

@Umcaruje Umcaruje commented May 30, 2017

Other than the formatting issue this works very good and fixes the issue at hand 👍

@tresf
Copy link
Member

@tresf tresf commented Jun 2, 2017

Other than the formatting issue this works very good and fixes the issue at hand

@BaraMGB fixed spacing via 0f4d921. Merging.

@tresf tresf merged commit cee68c7 into LMMS:stable-1.2 Jun 2, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
Fixes position marker height on startup
PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
Fixes position marker height on startup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.