Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes sample muting bug for sampletrack #3591

Merged
merged 2 commits into from Jun 8, 2017

Conversation

@BaraMGB
Copy link
Contributor

@BaraMGB BaraMGB commented May 30, 2017

fixes : #3590

@PhysSong
Copy link
Member

@PhysSong PhysSong commented May 30, 2017

Good.
Maybe #3133 have caused #3590.
Could we change SampleTrack::updateTcos() into simpler form?

@BaraMGB
Copy link
Contributor Author

@BaraMGB BaraMGB commented May 30, 2017

Could we change SampleTrack::updateTcos() into simpler form?

Yes, thinking about that brings me to another problem. If we have more than one sample track this would not work.

I'm on it.

@BaraMGB
Copy link
Contributor Author

@BaraMGB BaraMGB commented Jun 1, 2017

Yes, thinking about that brings me to another problem. If we have more than one sample track this would not work.

That's not true. I updated the PR.

@BaraMGB
Copy link
Contributor Author

@BaraMGB BaraMGB commented Jun 4, 2017

If no one has objections about this I'll merge in few hours.

@Umcaruje Umcaruje added this to the 1.2.0 milestone Jun 6, 2017
@Umcaruje Umcaruje added this to In Progress in Release 1.2.0 RC4 Jun 6, 2017
Copy link
Member

@zonkmachine zonkmachine left a comment

Tests fine. Looks good.

@BaraMGB BaraMGB merged commit 1435717 into LMMS:stable-1.2 Jun 8, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zonkmachine zonkmachine moved this from In Progress to Done in Release 1.2.0 RC4 Jun 8, 2017
tresf added a commit to liushuyu/lmms that referenced this pull request Jun 8, 2017
* fixes sample muting bug for sampletrack

* simplify SampleTrack::updateTcos
@tresf
Copy link
Member

@tresf tresf commented Jun 8, 2017

FYI, cherry-picked to liushuyu/merge via 8c17b39.

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
* fixes sample muting bug for sampletrack

* simplify SampleTrack::updateTcos
PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
* fixes sample muting bug for sampletrack

* simplify SampleTrack::updateTcos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.