fixes sample muting bug for sampletrack - #3591
Merged
Merged
Conversation
Member
Contributor
Author
Yes, thinking about that brings me to another problem. If we have more than one sample track this would not work. I'm on it. |
Contributor
Author
That's not true. I updated the PR. |
Contributor
Author
|
If no one has objections about this I'll merge in few hours. |
zonkmachine
approved these changes
Jun 8, 2017
zonkmachine
left a comment
zonkmachine
left a comment
Contributor
There was a problem hiding this comment.
Tests fine. Looks good.
tresf
pushed a commit
to liushuyu/lmms
that referenced
this pull request
Jun 8, 2017
* fixes sample muting bug for sampletrack * simplify SampleTrack::updateTcos
Member
|
FYI, cherry-picked to |
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 8, 2017
* fixes sample muting bug for sampletrack * simplify SampleTrack::updateTcos
PhysSong
pushed a commit
to PhysSong/lmms
that referenced
this pull request
Jul 8, 2017
* fixes sample muting bug for sampletrack * simplify SampleTrack::updateTcos
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
* fixes sample muting bug for sampletrack * simplify SampleTrack::updateTcos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes : #3590