Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes sample muting bug for sampletrack #3591

Merged
merged 2 commits into from
Jun 8, 2017
Merged

fixes sample muting bug for sampletrack #3591

merged 2 commits into from
Jun 8, 2017

Conversation

BaraMGB
Copy link
Contributor

@BaraMGB BaraMGB commented May 30, 2017

fixes : #3590

@PhysSong
Copy link
Member

PhysSong commented May 30, 2017 •
edited
Loading

Good.
Maybe #3133 have caused #3590.
Could we change SampleTrack::updateTcos() into simpler form?

@BaraMGB
Copy link
Contributor Author

BaraMGB commented May 30, 2017

Could we change SampleTrack::updateTcos() into simpler form?

Yes, thinking about that brings me to another problem. If we have more than one sample track this would not work.

I'm on it.

@BaraMGB
Copy link
Contributor Author

BaraMGB commented Jun 1, 2017

Yes, thinking about that brings me to another problem. If we have more than one sample track this would not work.

That's not true. I updated the PR.

@BaraMGB
Copy link
Contributor Author

BaraMGB commented Jun 4, 2017

If no one has objections about this I'll merge in few hours.

@Umcaruje Umcaruje added this to the 1.2.0 milestone Jun 6, 2017
zonkmachine
zonkmachine approved these changes Jun 8, 2017
View reviewed changes
Copy link
Contributor

@zonkmachine zonkmachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fine. Looks good.

@BaraMGB BaraMGB merged commit 1435717 into LMMS:stable-1.2 Jun 8, 2017
tresf pushed a commit to liushuyu/lmms that referenced this pull request Jun 8, 2017
@BaraMGB @tresf
fixes sample muting bug for sampletrack (LMMS#3591)
8c17b39 
* fixes sample muting bug for sampletrack

* simplify SampleTrack::updateTcos
@tresf
Copy link
Member

tresf commented Jun 8, 2017

FYI, cherry-picked to liushuyu/merge via 8c17b39.

PhysSong pushed a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
@BaraMGB @PhysSong
fixes sample muting bug for sampletrack (LMMS#3591)
a5e7ce7 
* fixes sample muting bug for sampletrack

* simplify SampleTrack::updateTcos
PhysSong pushed a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017
@BaraMGB @PhysSong
fixes sample muting bug for sampletrack (LMMS#3591)
7433483 
* fixes sample muting bug for sampletrack

* simplify SampleTrack::updateTcos
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@BaraMGB
fixes sample muting bug for sampletrack (LMMS#3591)
f39d137 
* fixes sample muting bug for sampletrack

* simplify SampleTrack::updateTcos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zonkmachine zonkmachine zonkmachine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

sampletrack mutes the playing sample by muting a different one
5 participants
@BaraMGB @PhysSong @tresf @zonkmachine @Umcaruje