New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overzealous cmake quoting #3604

Merged
merged 1 commit into from Jun 2, 2017

Conversation

Projects
None yet
1 participant
@tresf
Member

tresf commented Jun 2, 2017

Fixes builds from directories with spaces

CMake does a pretty good job of handling directories with spaces. For example, /foo bar/ is represented internally as /foo\ bar/. When double-quotes are added, it turns into "/foo\ bar/" which is invalid.

By removing double quotes, LMMS can be built from a directory with spaces in the name.

Fix overzealous quoting
Fixes builds from directories with spaces

@tresf tresf merged commit dd80268 into LMMS:stable-1.2 Jun 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tresf tresf deleted the tresf:quoting branch Jun 2, 2017

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Fix overzealous quoting (#3604)
Fixes builds from directories with spaces

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Fix overzealous quoting (#3604)
Fixes builds from directories with spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment