Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3616 by preventing fold overs for clipped data #3617

Merged

Conversation

michaelgregorius
Copy link
Contributor

Use libsndfile functionality to prevent fold overs when exporting clipped data. The fold overs occurred when exporting with a bit depth of 24 bit.

Use libsndfile functionality to prevent fold overs when exporting clipped
data. The fold overs occurred when exporting with a bit depth of 24 bit.
Copy link
Member

@zonkmachine zonkmachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes the issue. 24-bit wav files now clip the same way as 16-bit files.

@michaelgregorius michaelgregorius merged commit d3359f5 into LMMS:stable-1.2 Jun 7, 2017
@michaelgregorius michaelgregorius deleted the 3616-24-bit-clip-noise branch June 7, 2017 17:51
@tresf
Copy link
Member

tresf commented Jun 7, 2017

@liushuyu please add this to #3607. Nevermind, done via 283e320.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants