Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3616 by preventing fold overs for clipped data #3617

Merged

Conversation

@michaelgregorius
Copy link
Contributor

@michaelgregorius michaelgregorius commented Jun 6, 2017

Use libsndfile functionality to prevent fold overs when exporting clipped data. The fold overs occurred when exporting with a bit depth of 24 bit.

Use libsndfile functionality to prevent fold overs when exporting clipped
data. The fold overs occurred when exporting with a bit depth of 24 bit.
Copy link
Member

@zonkmachine zonkmachine left a comment

I can confirm that this fixes the issue. 24-bit wav files now clip the same way as 16-bit files.

@michaelgregorius michaelgregorius merged commit d3359f5 into LMMS:stable-1.2 Jun 7, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@michaelgregorius michaelgregorius deleted the michaelgregorius:3616-24-bit-clip-noise branch Jun 7, 2017
@tresf
Copy link
Member

@tresf tresf commented Jun 7, 2017

@liushuyu please add this to #3607. Nevermind, done via 283e320.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.