New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ogg files - Silence warning message and fix obsolete vorbis tag message #3634

Merged
merged 1 commit into from Jun 12, 2017

Conversation

Projects
None yet
2 participants
@zonkmachine
Member

zonkmachine commented Jun 11, 2017

We set the serial number on our generated Ogg files to 0 but it's supposed to be a unique number.
Furthermore 0 and UINT_32_MAXare to be avoided for some reason and that's what the message is about. Better give it some good numbers... :)
The documentation and code comments use int and uint32_t interchangeably and uint32_t was what we used previously so it should be fine.
Also, we stick the obsolete Linux Multimedia Studio to the end of the exported file. I change that to LMMS.

zonkmachine@zonkmachine:~/builds/lmms/lmms$ ogginfo ~/lmms/projects/*.ogg 
Processing file "/home/zonkmachine/lmms/projects/testfail.ogg"...

Note: Stream 1 has serial number 0, which is legal but may cause problems with some tools.
New logical stream (#1, serial: 00000000): type vorbis
Vorbis headers parsed for stream 1, information follows...
Version: 0
Vendor: Xiph.Org libVorbis I 20101101 (Schaufenugget)
Channels: 2
Rate: 44100

Nominal bitrate: 160.000000 kb/s
Upper bitrate: 160.000000 kb/s
Lower bitrate: 160.000000 kb/s
User comments section follows...
	Cool=This song has been made using Linux MultiMedia Studio
Vorbis stream 1:
	Total data length: 329973 bytes
	Playback length: 0m:16.486s
	Average bitrate: 160.121141 kb/s
Logical stream 1 ended

Fixed serial number (serial: faf21bb8) and message is updated.

Processing file "/home/zonkmachine/lmms/projects/testfixed.ogg"...

New logical stream (#1, serial: faf21bb8): type vorbis
Vorbis headers parsed for stream 1, information follows...
Version: 0
...
User comments section follows...
	Cool=This song has been made using LMMS
Vorbis stream 1:
...
Logical stream 1 ended
@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Jun 12, 2017

Member

This looks good. The output compares to Audacity. I'll merge this tomorrow if there are no complaints.

Member

zonkmachine commented Jun 12, 2017

This looks good. The output compares to Audacity. I'll merge this tomorrow if there are no complaints.

Silence warning message and fix obsolete vorbis tag message
We give the stream a unique serial number and make sure it
isn't '0' or 'UINT_32_MAX'.
Change obsolete 'Linux MultiMedia Studio' to 'LMMS' in
ogg file comment.

@zonkmachine zonkmachine merged commit c53dd31 into LMMS:stable-1.2 Jun 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Jun 12, 2017

Member

if there are no complaints.

This is nice, but as a reminder, we should target non-critical fixes at master. :)

Member

tresf commented Jun 12, 2017

if there are no complaints.

This is nice, but as a reminder, we should target non-critical fixes at master. :)

tresf added a commit to liushuyu/lmms that referenced this pull request Jun 12, 2017

Silence warning message and fix obsolete vorbis tag message (#3634)
We give the stream a unique serial number and make sure it
isn't '0' or 'UINT_32_MAX'.
Change obsolete 'Linux MultiMedia Studio' to 'LMMS' in
ogg file comment.
@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Jun 12, 2017

Member

OK ... ;)

Member

zonkmachine commented Jun 12, 2017

OK ... ;)

@zonkmachine zonkmachine deleted the zonkmachine:ogginit branch Jun 12, 2017

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Jun 12, 2017

Member

Cherry-picked and ready for master via cb68c96.

Member

tresf commented Jun 12, 2017

Cherry-picked and ready for master via cb68c96.

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Silence warning message and fix obsolete vorbis tag message (#3634)
We give the stream a unique serial number and make sure it
isn't '0' or 'UINT_32_MAX'.
Change obsolete 'Linux MultiMedia Studio' to 'LMMS' in
ogg file comment.

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Silence warning message and fix obsolete vorbis tag message (#3634)
We give the stream a unique serial number and make sure it
isn't '0' or 'UINT_32_MAX'.
Change obsolete 'Linux MultiMedia Studio' to 'LMMS' in
ogg file comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment