Update classic/style.css with TabWidget, TrackView, PianoView and Fader colors

[PhysSong]

It fixes #3652 by adding TabWidget color settings to classic/style.css.
@Umcaruje @RebeccaLaVie If you don't like this color, please change it.

[PhysSong]

@Umcaruje Now you can push commits on my fork. Please change colors appropriately.

[tresf]

@Umcaruje @RebeccaLaVie If you don't like this color, please change it.

@PhysSong Can you please provide a preview of this PR? That would make the decision a bit quicker.

[PhysSong]

@tresf I can't provide preview right now. Currently colors are the same as default theme.

[Umcaruje]

I'll look into this today

[Umcaruje]

I updated the colors:

I also ran a diff between the two themes, and updated some other changes in the classic theme that we missed, so the files now should have the identical rules, just different colors.

[PhysSong]

@Umcaruje Great job! Thanks a lot.
Is it ready for merge?

[Umcaruje]

I'll leave this open for 12 hours if anyone wants to chime in, I'll merge afterwards.

[tresf]

These lines don't appear to have been changed and the formatting is inconsistent.

[tresf]

I see a lot of unnecessary formatting changes. Can we just change the lines that are needed for the PR? data/themes/default/style.css shouldn't even be in this PR. The more lines we touch, the harder it is to rebase onto master.

[Umcaruje]

The thing is that I tried to make the formatting consistent throughout the file, cause it was all over the place, and using spaces instead of tabs. I am not aware of any theme changes on master, so I don't think rebasing this would be a problem.

[PhysSong]

@tresf Yes. default/style.css shouldn't in this PR.
We need only fix difference between two css file. Formatting is what @Umcaruje should do after this PR is merged.

[tresf]

Formatting is what @Umcaruje should do after this PR is merged.

Formatting should be targeted at master, really and we have an initiative to do formatting cleanup anyway. Stable branches are not actively developed, so making the source more readable serves no purpose.

[PhysSong]

@tresf @Umcaruje If there's no objection, I'll revert last three commits and andd a commit to remove unnecessary formatting change.
I will also provide diff file between re-formatted css and one without formatting change. @Umcaruje You will be able to use the diff for further formatting.

[Umcaruje]

@tresf @Umcaruje If there's no objection, I'll revert last three commits and andd a commit to remove unnecessary formatting change.
I will also provide diff file between re-formatted css and one without formatting change. @Umcaruje You will be able to use the diff for further formatting.

Or I can just re-commit the 5 lines I changed tommorow, you two make good points and I'll fix this :)

[PhysSong]

@Umcaruje I can do it soon. Would the commits be squashed on merge?
@tresf Thanks for your feedback!

[Umcaruje]

Would the commits be squashed on merge?

Yeah, thanks for working on this. Don't forget the changes in Fader and the track background and the piano widget :)

[tresf]

Would the commits be squashed on merge?

Yes, that is our default option, so they'd be squashed unless asked otherwise.

[PhysSong]

I reverted formatting changes. I also attached the diff for further formatting.

[PhysSong]

Travis CI is failing, but it isn't a problem obviously.
See this.

[zonkmachine]

Travis CI is failing, but it isn't a problem obviously.

I restarted the failing build. ✅

[PhysSong]

@Umcaruje Now fixed.

[Umcaruje]

@PhysSong thank you very much for your work on this, this is ready to merge 👍