/ lmms Public
MIDI - Don't apply base velocity to all controller values #3678
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
I noticed the sustain pedal was affected by setting the base velocity. Turn down the velocity under MIDI settings and eventually the threshold for value 'on' (64) is no longer reached. I've moved that part of the code in
MidiPort::processInEvent()to within the part handling note on/off/keypressure.
I haven't tried this with other control messages than sustain yet.