Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
MIDI - Don't apply base velocity to all controller values #3678
I noticed the sustain pedal was affected by setting the base velocity. Turn down the velocity under MIDI settings and eventually the threshold for value 'on' (64) is no longer reached. I've moved that part of the code in
I'll merge this tomorrow if there are no objections.
After touch messages are filtered together with key on/off and the pressure level is set to the velocity level. This behaviour looks a bit suboptimal if you ask me. I think this probably needs some more design and is better handled in master. In any case this is not a new behaviour for 1.2.0 .