New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI - Don't apply base velocity to all controller values #3678

Merged
merged 1 commit into from Jul 6, 2017

Conversation

Projects
None yet
1 participant
@zonkmachine
Member

zonkmachine commented Jul 3, 2017

I noticed the sustain pedal was affected by setting the base velocity. Turn down the velocity under MIDI settings and eventually the threshold for value 'on' (64) is no longer reached. I've moved that part of the code in MidiPort::processInEvent() to within the part handling note on/off/keypressure.
I haven't tried this with other control messages than sustain yet.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Jul 5, 2017

Member

I'll merge this tomorrow if there are no objections.

After touch messages are filtered together with key on/off and the pressure level is set to the velocity level. This behaviour looks a bit suboptimal if you ask me. I think this probably needs some more design and is better handled in master. In any case this is not a new behaviour for 1.2.0 .

Member

zonkmachine commented Jul 5, 2017

I'll merge this tomorrow if there are no objections.

After touch messages are filtered together with key on/off and the pressure level is set to the velocity level. This behaviour looks a bit suboptimal if you ask me. I think this probably needs some more design and is better handled in master. In any case this is not a new behaviour for 1.2.0 .

@zonkmachine zonkmachine merged commit d65e1a3 into LMMS:stable-1.2 Jul 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zonkmachine zonkmachine deleted the zonkmachine:midicontrollervalues branch Jul 7, 2017

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

PhysSong added a commit to PhysSong/lmms that referenced this pull request Jul 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment