Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Clean up after render in ProjectRenderer destructor #3680
We need to wait with calling Mixer::restoreAudioDevice() and
Edit: This works just fine...
referenced this pull request
Jul 3, 2017
i tested the projects on win32 xp3 RC3
Project rendercrash also crashes for me with default render-settings for wave, but the wave-file was exported, and in full length!
Thanks for testing this!
I should have mentioned that it doesn't happen every time. Please try it some more with this project and see if you can break it. 8)
I'm the bug on that one. Working fast and cloning tracks... Boom!
Wave or ogg shouldn't matter. Just export 20 times each project and see how often they break.
Yes, the crash happens at the end of export. I imagine that you could end up with both broken exports and finished working files but I haven't tested that fully.
I've exported ogg and wav files now and I always end up with a successful output file.
I'm going to merge this tomorrow. Testing/Review is most welcome.
Jul 7, 2017
1 check passed
There are too many variables that differ here so I no point in comparing setups. In your case you have a weaker computer than I do and your OS is much older, win XP. This issue is related to multiple threads and multi threading is being done differently by Qt on different platforms so we could be trouble shooting this until the next millennium. The code has already been committed to stable-1.2 and will be in RC4 and then you can test it again to see if the crash (hopefully) is gone.