Fix deadlock when exporting is finished, if the project has any Sample TCO(s). #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested, works! Exported from gui and command line, single samples and complex projects. |
zonkmachine
approved these changes
Aug 1, 2017
|
Merge? |
|
@PhysSong I'll 'bump' this to master too. |
zonkmachine
pushed a commit
that referenced
this pull request
Aug 2, 2017
…e TCO(s). (#3742) [cherry-picked from stable-1.2]
|
@zonkmachine Does it really needed? This will be in |
|
?! You're right there. I don't know where I got the idea that this was the way to go actually... |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
…e TCO(s). (LMMS#3742) [cherry-picked from stable-1.2]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3344.
Calls
stopProcessing()when the rendering ends, to preventrequsetChangeInModels()from waiting forrunChangesInModels(), which causes a deadlock.#3344 (comment) is another solution, but this one is more fundamental than #3344 (comment).
Tested for both GUI and CLI, and both single-file rendering and rendering per track, works well.