Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paint a black rectangle under patterns to prevent glitches #3759

Merged
merged 1 commit into from Aug 17, 2017

Conversation

@Umcaruje
Copy link
Member

@Umcaruje Umcaruje commented Aug 8, 2017

Fixes #3709

As suggested by @michaelgregorius I added a black rectangle to act as a background for the patterns. No more glitches. Here are transparent patterns with some random-ass colors:
screenshot from 2017-08-08 14 33 27

@gi0e5b06
Copy link

@gi0e5b06 gi0e5b06 commented Aug 8, 2017

What's the point of having transparent colors if you paint the background?

@Umcaruje
Copy link
Member Author

@Umcaruje Umcaruje commented Aug 8, 2017

@gi0e5b06 there's absolutely no point to them now, but if someone does this in a custom theme they won't see it as an issue

@michaelgregorius michaelgregorius self-requested a review Aug 9, 2017
Copy link
Contributor

@michaelgregorius michaelgregorius left a comment

@Umcaruje I have built it from your repository and it looks good to me!

@Umcaruje Umcaruje merged commit 206a08e into LMMS:stable-1.2 Aug 17, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.