Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paint a black rectangle under patterns to prevent glitches #3759

merged 1 commit into from Aug 17, 2017


Copy link

@Umcaruje Umcaruje commented Aug 8, 2017

Fixes #3709

As suggested by @michaelgregorius I added a black rectangle to act as a background for the patterns. No more glitches. Here are transparent patterns with some random-ass colors:
screenshot from 2017-08-08 14 33 27

Copy link

gi0e5b06 commented Aug 8, 2017

What's the point of having transparent colors if you paint the background?

Copy link
Member Author

Umcaruje commented Aug 8, 2017

@gi0e5b06 there's absolutely no point to them now, but if someone does this in a custom theme they won't see it as an issue

Copy link

@michaelgregorius michaelgregorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Umcaruje I have built it from your repository and it looks good to me!

@Umcaruje Umcaruje merged commit 206a08e into LMMS:stable-1.2 Aug 17, 2017
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants