New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paint a black rectangle under patterns to prevent glitches #3759

Merged
merged 1 commit into from Aug 17, 2017

Conversation

Projects
None yet
3 participants
@Umcaruje
Member

Umcaruje commented Aug 8, 2017

Fixes #3709

As suggested by @michaelgregorius I added a black rectangle to act as a background for the patterns. No more glitches. Here are transparent patterns with some random-ass colors:
screenshot from 2017-08-08 14 33 27

@gi0e5b06

This comment has been minimized.

Show comment
Hide comment
@gi0e5b06

gi0e5b06 Aug 8, 2017

What's the point of having transparent colors if you paint the background?

gi0e5b06 commented Aug 8, 2017

What's the point of having transparent colors if you paint the background?

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Aug 8, 2017

Member

@gi0e5b06 there's absolutely no point to them now, but if someone does this in a custom theme they won't see it as an issue

Member

Umcaruje commented Aug 8, 2017

@gi0e5b06 there's absolutely no point to them now, but if someone does this in a custom theme they won't see it as an issue

@michaelgregorius michaelgregorius self-requested a review Aug 9, 2017

@michaelgregorius

@Umcaruje I have built it from your repository and it looks good to me!

@Umcaruje Umcaruje merged commit 206a08e into LMMS:stable-1.2 Aug 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment