New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix producing of NaN from Env/LFO parameter change while playing. #3761

Merged
merged 2 commits into from Aug 12, 2017

Conversation

Projects
None yet
3 participants
@PhysSong
Member

PhysSong commented Aug 10, 2017

Fixes #3408.

Guarantee thread safety to ensure fillLevel() not to read value from wrong buffer address, because of buffer reallocation in updateSampleVars().

Fix producing of NaN from Env/LFO parameter change while playing.
Guarantee thread safety to ensure fillLevel() not to read value from
wrong buffer address.

@PhysSong PhysSong requested a review from zonkmachine Aug 10, 2017

@PhysSong PhysSong referenced this pull request Aug 10, 2017

Closed

Envelope triggered NaN #3408

@michaelgregorius

Please use QMutexLockers to ensure safe unlocking in cases of exceptions, etc.

Show outdated Hide outdated src/core/EnvelopeAndLfoParameters.cpp
Show outdated Hide outdated src/core/EnvelopeAndLfoParameters.cpp
@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong
Member

PhysSong commented Aug 10, 2017

@michaelgregorius Done via 667ee11.

@zonkmachine

Tested. Issue fixed.

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Aug 11, 2017

Member

I'll merge it after 12~24 hours if there's no objection.

Member

PhysSong commented Aug 11, 2017

I'll merge it after 12~24 hours if there's no objection.

@PhysSong PhysSong merged commit 88cc586 into LMMS:stable-1.2 Aug 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PhysSong PhysSong deleted the PhysSong:env-nan branch Aug 12, 2017

PhysSong added a commit to PhysSong/lmms that referenced this pull request Aug 19, 2017

Fix producing of NaN from Env/LFO parameter change while playing (#3761)
Guarantee thread safety to ensure fillLevel() not to read value from
wrong buffer address.

PhysSong added a commit to PhysSong/lmms that referenced this pull request Aug 25, 2017

Fix producing of NaN from Env/LFO parameter change while playing (#3761)
Guarantee thread safety to ensure fillLevel() not to read value from
wrong buffer address.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment