Restrict playing notes on the keyboard of the Piano Roll editor to left-clicks.

[husamalhomsi]

This will restrict playing notes on the keyboard of the Piano Roll editor to left-clicks, so middle-clicking a key will not play its note.
Also, left-clicking a key and dragging up or down will play the keys that were dragged over, but middle-clicking doesn't, it just sticks to the note that was middle-clicked on.

[husamalhomsi]

I forgot that LMMS:stable-1.2 is for bug fixes concerning the 1.2 release. 😅
Is there a way to change where my commit will be merged into, other than closing this pull request and opening another one?
I want the commit to be merged into LMMS:Master instead of LMMS:stable-1.2 because that would be more appropriate.

[tresf]

I want the commit to be merged into LMMS:Master instead of LMMS:stable-1.2 because that would be more appropriate.

I tried to switch it but weird stuff happens. Probably best to open a new PR.

[Umcaruje]

You can probably do this:

# Soft reset the branch
git reset --soft stable-1.2
# Stash the changes
git stash
# Hard reset to master
git reset --hard upstream/master
# Bring back the stashed changes
git stash pop
# Force push
git push -f

Then set the base branch to master

P.S. I'd backup the work just in case but this should work

[husamalhomsi]

I just forked LMMS/lmms and did these small changes online. I don't have a local copy of the repo.
@Umcaruje I think the commands you mentioned will work if I have a local copy. Is there a way to set Sawuare/lmms to be like my working directory while I don't have a local copy of it, so I can execute these commands?

[zonkmachine]

I just forked LMMS/lmms and did these small changes online. I don't have a local copy of the repo.

But have you compiled it on your own machine at all? Working from the online editor won't really work as you need to actually compile and test your changes yourself.

Is there a way to set Sawuare/lmms to be like my working directory while I don't have a local copy of it, so I can execute these commands?

No. You should clone Sawuare/lmms as described here and then add build and target directories and compile it as described here.

Before you start working on something you have to create a separate branch.
Something like:
git checkout master
git checkout -b restrictnotes

Then you can either push over this PR or close this one and open a new one (easier).

[husamalhomsi]

@zonkmachine

I never compiled it on my machine. I worked from the online editor because the changes I made were very small that I didn't think they would need testing.

The problem is that I don't have access to my machine right now. :(
I will clone, create a seperate branch, compile, test and push over this PR as soon as I get access to my machine. ;)

[PhysSong]

Now the base branch can be switched safely thanks to 12edb58.

[husamalhomsi]

Tested this and it works. Merge?