-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Restrict playing notes on the keyboard of the Piano Roll editor to left-clicks. #3771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ft-clicks. This will restrict playing notes on the keyboard of the Piano Roll editor to left-clicks, so middle-clicking a key will not play its note.
I forgot that |
I tried to switch it but weird stuff happens. Probably best to open a new PR. |
You can probably do this: # Soft reset the branch
git reset --soft stable-1.2
# Stash the changes
git stash
# Hard reset to master
git reset --hard upstream/master
# Bring back the stashed changes
git stash pop
# Force push
git push -f Then set the base branch to master P.S. I'd backup the work just in case but this should work |
I just forked LMMS/lmms and did these small changes online. I don't have a local copy of the repo. |
But have you compiled it on your own machine at all? Working from the online editor won't really work as you need to actually compile and test your changes yourself.
No. You should clone Before you start working on something you have to create a separate branch. Then you can either push over this PR or close this one and open a new one (easier). |
I never compiled it on my machine. I worked from the online editor because the changes I made were very small that I didn't think they would need testing. The problem is that I don't have access to my machine right now. :( |
Now the base branch can be switched safely thanks to 12edb58. |
Tested this and it works. Merge? |
…ft-clicks. (LMMS#3771) Restrict playing notes on the keyboard of the Piano Roll editor to left-clicks
This will restrict playing notes on the keyboard of the Piano Roll editor to left-clicks, so middle-clicking a key will not play its note.
Also, left-clicking a key and dragging up or down will play the keys that were dragged over, but middle-clicking doesn't, it just sticks to the note that was middle-clicked on.