Skip to content

General improvements and fixes - #3772

Merged
zonkmachine merged 1 commit into
LMMS:masterfrom
ArashPartow:master
Aug 23, 2017
Merged

General improvements and fixes#3772
zonkmachine merged 1 commit into
LMMS:masterfrom
ArashPartow:master

Conversation

@ArashPartow

Copy link
Copy Markdown
Contributor

Added fixes for a clean GCC 7.+ compile

Added fixes for a clean GCC 7.+ compile
@zonkmachine

Copy link
Copy Markdown
Contributor

Thanks for the update!

@zonkmachine
zonkmachine merged commit 8dcf997 into LMMS:master Aug 23, 2017
@ArashPartow

Copy link
Copy Markdown
Contributor Author

You're welcome! :D

zonkmachine pushed a commit to zonkmachine/lmms that referenced this pull request Oct 1, 2017
Added fixes for a clean GCC 7.+ compile
@tresf

tresf commented Nov 11, 2017

Copy link
Copy Markdown
Member

@ArashPartow we're hitting some compilation issues on Travis-CI with Mac/Clang with the version from your branch (we just switched).

Is our version different than yours? https://travis-ci.org/LMMS/lmms/jobs/300470102

Edit: Yes it is different. Our version has const removed. More info here: #3965

e.g.

/Users/travis/build/LMMS/lmms/plugins/Xpressive/exprtk/exprtk.hpp:1965:64: error: default initialization of an object of const type 'const typename numeric::details::number_type<double>::type' (aka 'const exprtk::details::numeric::details::real_type_tag') without a user-provided default constructor
         const typename numeric::details::number_type<T>::type num_type;
                                                               ^
                                                                       {}
/Users/travis/build/LMMS/lmms/plugins/Xpressive/exprtk/exprtk.hpp:3460:41: note: in instantiation of function template specialization 'exprtk::details::string_to_real<double>' requested here
                  if (!exprtk::details::string_to_real(t.value,v))
                                        ^
/Users/travis/build/LMMS/lmms/plugins/Xpressive/exprtk/exprtk.hpp:1965:64: error: default initialization of an object of const type 'const typename numeric::details::number_type<float>::type' (aka 'const exprtk::details::numeric::details::real_type_tag') without a user-provided default constructor
         const typename numeric::details::number_type<T>::type num_type;
                                                               ^

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Added fixes for a clean GCC 7.+ compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants