Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress midi in events on export #3778

Merged
merged 1 commit into from Sep 12, 2017

Conversation

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Aug 26, 2017

Addresses #3747. This suppresses midi events (sustain pedal, key press) triggered during export. It does however not clear out midi events in effect while starting the export.

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Aug 27, 2017

If sustin pedal have been pressed before export, it will be exported. Before rendering, all notes should be silenced and sustain pedal should be marked as released.

@zonkmachine
Copy link
Member Author

@zonkmachine zonkmachine commented Aug 27, 2017

If sustin pedal have been pressed before export, it will be exported.

Which this PR doesn't take care of. It's a partial fix as mentioned here. I don't have time to dive into the issue more.

@zonkmachine
Copy link
Member Author

@zonkmachine zonkmachine commented Sep 11, 2017

I'm merging this tomorrow if there are no other complaints. #3747 isn't marked for 1.2.0 and shouldn't be. This PR will make the issue less prominent.

@PhysSong
Copy link
Member

@PhysSong PhysSong commented Sep 11, 2017

I'm going to test this after my works for rc4 finish. If I find any regressions, I'll request changes. Otherwise, it's good👍

Copy link
Member

@PhysSong PhysSong left a comment

Tested. Just a note:
If you press keys/sustain pedal before exporting, there are no ways to correct during the export. It doesn't matter much since those keys/pedals breaks output even they can be canceled.
Such things should be handled somehow, but it can be done later.

@zonkmachine
Copy link
Member Author

@zonkmachine zonkmachine commented Sep 12, 2017

Tested. Just a note:
If you press keys/sustain pedal before exporting, there are no ways to correct during the export.

OK. I think I've already commented on this.

Merging 🐳

@zonkmachine zonkmachine merged commit f26a02d into LMMS:stable-1.2 Sep 12, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zonkmachine zonkmachine deleted the zonkmachine:suppressmidionexport branch Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.