Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some memory leaks #3779

Merged
merged 2 commits into from Aug 28, 2017
Merged

Fix some memory leaks #3779

merged 2 commits into from Aug 28, 2017

Conversation

@lukas-w
Copy link
Member

@lukas-w lukas-w commented Aug 27, 2017

No description provided.

{
QString* errors = new QString();
QString errors = m_errors.join('\n') + '\n';

This comment has been minimized.

@irrenhaus3

irrenhaus3 Aug 27, 2017
Contributor

Constructor of QString expects a const char* here. Change the '\n's to "\n" to make them string literals.

This comment has been minimized.

@lukas-w

lukas-w Aug 27, 2017
Author Member

Yup, although it's the join function that expects const char*, not the constructor. Appears to be a Qt5-only feature.

This comment has been minimized.

@lukas-w

lukas-w Aug 28, 2017
Author Member

Fixed via 670ca4f

@lukas-w lukas-w merged commit 24d320d into stable-1.2 Aug 28, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@lukas-w lukas-w deleted the fix/memory-leaks branch Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.