Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vibed when the "P" parameter has non-zero value #3789

Merged
merged 1 commit into from Sep 6, 2017
Merged

Fix Vibed when the "P" parameter has non-zero value #3789

merged 1 commit into from Sep 6, 2017

Conversation

PhysSong
Copy link
Member

@PhysSong PhysSong commented Sep 3, 2017

Fixes #3663. Current code reads value data from wrong indexes.
To correct it, - 1 have been added.

@PhysSong
Copy link
Member Author

PhysSong commented Sep 5, 2017

Merge? Or change the base branch?

zonkmachine
zonkmachine approved these changes Sep 6, 2017
View changes
Copy link
Member

@zonkmachine zonkmachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I can't replicate the issue with this PR.
I think merge.

@PhysSong PhysSong merged commit 9d7c340 into LMMS:stable-1.2 Sep 6, 2017
@PhysSong PhysSong deleted the vibed_fix branch September 6, 2017 08:57
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@PhysSong
Fix Vibed when the "P" parameter has non-zero value (LMMS#3789)
6fcc8a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zonkmachine zonkmachine zonkmachine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PhysSong @zonkmachine