Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CTRL in songeditor by losing focus #3796

Merged
merged 2 commits into from
Sep 12, 2017
Merged

Conversation

BaraMGB
Copy link
Contributor

@BaraMGB BaraMGB commented Sep 7, 2017

fixes #3795

@BaraMGB BaraMGB requested a review from PhysSong September 7, 2017 11:41
Copy link
Member

@PhysSong PhysSong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works great!

Copy link
Member

@PhysSong PhysSong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done more tests and it seems to crash occasionally after your commit, at least for some specific projects. Investigating...

@PhysSong
Copy link
Member

PhysSong commented Sep 10, 2017

It's because of uninitialized m_crtlAction. Whenever it crashes, that have non-NULL value in constructor.
Initializating it to NULL fixes crash 👍

@BaraMGB
Copy link
Contributor Author

BaraMGB commented Sep 10, 2017

Thanks for investigation! I will add the initialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants