Skip to content

fix CTRL in songeditor by losing focus#3796

Merged
BaraMGB merged 2 commits into
LMMS:masterfrom
BaraMGB:songeditorctrlbug
Sep 12, 2017
Merged

fix CTRL in songeditor by losing focus#3796
BaraMGB merged 2 commits into
LMMS:masterfrom
BaraMGB:songeditorctrlbug

Conversation

@BaraMGB

@BaraMGB BaraMGB commented Sep 7, 2017

Copy link
Copy Markdown
Contributor

fixes #3795

@BaraMGB BaraMGB requested a review from PhysSong September 7, 2017 11:41

@PhysSong PhysSong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works great!

@PhysSong PhysSong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done more tests and it seems to crash occasionally after your commit, at least for some specific projects. Investigating...

@PhysSong

PhysSong commented Sep 10, 2017

Copy link
Copy Markdown
Member

It's because of uninitialized m_crtlAction. Whenever it crashes, that have non-NULL value in constructor.
Initializating it to NULL fixes crash 👍

@BaraMGB

BaraMGB commented Sep 10, 2017

Copy link
Copy Markdown
Contributor Author

Thanks for investigation! I will add the initialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants