New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recording of single streamed instruments(regression in #3774) #3803

Merged
merged 2 commits into from Sep 18, 2017

Conversation

Projects
3 participants
@PhysSong
Member

PhysSong commented Sep 11, 2017

Fixes #3774 (comment), reverts #3774 and provides a new fix for #3757 using the solution in #3757 (comment).
As a side effect, It works as a temporary solution for #3777. However, #3777 still needs a permanent solution like #3774 (comment).

@PhysSong PhysSong requested a review from zonkmachine Sep 11, 2017

@PhysSong PhysSong added this to In Progress in Release 1.2.0 RC4 Sep 11, 2017

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Sep 11, 2017

Member

I won't be able to test this as I'm away from home.

Member

zonkmachine commented Sep 11, 2017

I won't be able to test this as I'm away from home.

@zonkmachine zonkmachine removed their request for review Sep 11, 2017

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Sep 11, 2017

Member

Okay... Is there anyone who can test it?

Member

PhysSong commented Sep 11, 2017

Okay... Is there anyone who can test it?

@PhysSong PhysSong changed the title from Fix recording of single streamed instruments to Fix recording of single streamed instruments(regression in #3774) Sep 18, 2017

@Umcaruje

Tested this, works as expected and fixes the issues in hand.

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Sep 18, 2017

Member

Merge?

Member

PhysSong commented Sep 18, 2017

Merge?

@Umcaruje Umcaruje merged commit 4e3c6b0 into LMMS:stable-1.2 Sep 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Umcaruje Umcaruje moved this from In Progress to Done in Release 1.2.0 RC4 Sep 18, 2017

@PhysSong PhysSong deleted the PhysSong:singlestreamrec branch Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment