Fix recording of single streamed instruments(regression in #3774) - #3803
Merged
Conversation
Contributor
|
I won't be able to test this as I'm away from home. |
zonkmachine
removed their request for review
September 11, 2017 10:27
Member
Author
|
Okay... Is there anyone who can test it? |
PhysSong
changed the title
Umcaruje
approved these changes
Sep 18, 2017
Umcaruje
left a comment
Umcaruje
left a comment
Member
There was a problem hiding this comment.
Tested this, works as expected and fixes the issues in hand.
Member
Author
|
Merge? |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
…LMMS#3803) * Revert "same note layering when sustain pedal is pressed (LMMS#3774)" This reverts commit ab80176. * Fix recording of sustained notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3774 (comment), reverts #3774 and provides a new fix for #3757 using the solution in #3757 (comment).
As a side effect, It works as a temporary solution for #3777. However, #3777 still needs a permanent solution like #3774 (comment).