New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sound while playing from piano roll, when BB tracks are muted #3804

Merged
merged 2 commits into from Sep 28, 2017

Conversation

Projects
None yet
3 participants
@PhysSong
Member

PhysSong commented Sep 11, 2017

Fixes #1947, fixes #3379.
First commit fixes playback for patterns in main song. If a track is not in the BBTrackContainer, we don't need to set parent BB track of play handle.
Second commit is about pattens in BB. A pattern in BB editor won't be played if the parent BB track is muted. The only exception is playing the pattern in Piano-Roll. So this commit fixes this exceptional case.

@zonkmachine zonkmachine added this to the 1.2.0 milestone Sep 25, 2017

@PhysSong PhysSong requested a review from Umcaruje Sep 27, 2017

@Umcaruje

This works like a charm, and fixes both the bugs 👍

@PhysSong PhysSong merged commit e5db275 into LMMS:stable-1.2 Sep 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PhysSong PhysSong deleted the PhysSong:mutedbbsound branch Sep 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment