Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use VST-provided memory when loading chunks #3805

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

DomClark
Copy link
Member

Fixes #493. May potentially break some other plugins, see this comment on the issue.

@Umcaruje
Copy link
Member

I tested this on Linux Qt4, this fixes the crash when loading the VST. I also opened Synth1, and it performed as expected.

The plugin has another quirk on linux, it's GUI disappears when interacted with, but this was not introduced with this PR, so I believe it would deem an issue of it's own. (I'd like to test with qt5 first before making one though)
gifrecord_2017-09-18_221823

@Umcaruje Umcaruje merged commit fb5a58a into LMMS:stable-1.2 Sep 20, 2017
@musikBear
Copy link

The plugin has another quirk on linux

@Umcaruje Looks a lot like a re-draw issue, so the behaviour could be different with different graphic hw.
I see this in other GUIs, but there it appears as black blocks. They are fixed on my hw, by pushing the UI slowly into the edge of the screen, and bringing it back.

@tresf
Copy link
Member

tresf commented Sep 21, 2017

@musikBear there may also be Wine logs that have some errors. P.S. Stop using Windows XP.

@zonkmachine
Copy link
Member

P.S. Stop using Windows XP.

@musikBear I think what @tresf is refering to here, more specifically, is a later OS (Windows Vista not included).

@musikBear
Copy link

💸 is actually the issue.. Not laziness or incompetence 💸

@DomClark DomClark deleted the kairatunecrash branch March 12, 2021 18:55
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants