You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@devnexen thanks! This has been breaking on my machine as well. Can you please also submit a PR to https://github.com/swh/ladspa? (this redundant exercise won't be necessary once we get #3489 properly coded, merged and submoduled).
I'm sorry for the inconvenience, but since this is needed for our next stable release, we will need to be merged into stable-1.2 and then we'll sync it back to master. This may seem counter-intuitive, but that's how we're handling the branch drifting. I've attempted to rebase using the GitHub GUI, but it threw the PR out of whack. After switching this to go against stable-1.2 I believe the branch needs to be rewound to the state of stable-1.2 and then the commit can be cherry-picked and the PR should be OK. This will auto-close the PR if the commit isn't cherry-picked before pushing. (that's what happens if state of HEAD matches comparison HEAD). So it may be easier to just open a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted on OS X.