Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3842: Opening a project with LB302 with specific waveforms produces a noise burst. #3844



Copy link

@michaelgregorius michaelgregorius commented Sep 30, 2017

Fix the problem described in #3842 by removing a duplicate initialization of a VCA variable. Also clean up some code by

  • moving the initialization of the VCA related variables into the constructor initializer list and
  • introducing an enum for the VCA mode.

Fix the noise burst described in LMMS#3842 by removing the second
initialization of vca_a to 9 in the constructor of lb302Synth.
Move the initialization of the members belonging to the VCA into
lb302Synth's constructor initializer list. This also removes a
duplication initialization of vca_mode from the code.
Replace the integer encoding of the VCA mode with an enumeration.
Copy link

Fix confirmed. Code looks fine...

@michaelgregorius michaelgregorius merged commit b1af4c2 into LMMS:master Oct 1, 2017
@michaelgregorius michaelgregorius deleted the 3842-Remove-LB302-Noise-Burst branch October 1, 2017 09:51
Copy link

zonkmachine commented Oct 30, 2017

I don't know where but I vaguely remember suggesting this should go in master/1.3.
It should however be backported to 1.2 .

Copy link

8ad46aa is now in stable-1.2 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants