New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the arpeggiator #3858

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
1 participant
@zonkmachine
Member

zonkmachine commented Oct 5, 2017

Fixing some of the issues with the arpeggiator.

  • The decay of the last arpeggio note is added to the length of the master note so after the first run there will be extra notes played along with the arpeggio, forming chords or doubling the notes for increased volume.
    * * *Fix reverted* * *

  • Sort mode. If the envelopes are off, the notes that should be silent are playing as ordinary notes while waiting for their turn. Solving this by using the same hack as the 'skip' algorithm as it had the same issue.
    Set as master note.

Adresses #3342


Issues remaining

  • Sort mode. Sometimes notes are skipped.
  • Sort mode. There is no way to know in which order the notes are being handled without displacing them. This is a pretty good way to deal with it actually but it would be better if the default would be to start with the lowest note and then work our way up. To fix this we probably need to sort the cnphv after key value.
  • Skip function. This may only apply to lb302... If you drag an lb302 over a track with envelopes those affect the lb302 in such a way that notes keep sounding, in a legato kind of way, for as long as notes after it are skipped.

Edit: New arpeggiator meta issue opened here: #3880

@zonkmachine zonkmachine added this to the 1.2.0 milestone Oct 5, 2017

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Oct 5, 2017

Member

Note:
Arpeggiator sometimes drops notes when handling more than one base note at a time. This is true for all sync modes and is not related to this PR.

Member

zonkmachine commented Oct 5, 2017

Note:
Arpeggiator sometimes drops notes when handling more than one base note at a time. This is true for all sync modes and is not related to this PR.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Oct 6, 2017

Member

This fixes #340
Testing appreciated. I'll merge this tomorrow if no one objects.

Member

zonkmachine commented Oct 6, 2017

This fixes #340
Testing appreciated. I'll merge this tomorrow if no one objects.

@zonkmachine zonkmachine changed the title from Decay length shouldn't affect the length of the arpeggiated master note to Fixing the arpeggiator Oct 7, 2017

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Oct 7, 2017

Member

I went ahead and fixed up some other issues. Merge will wait.

Member

zonkmachine commented Oct 7, 2017

I went ahead and fixed up some other issues. Merge will wait.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Oct 8, 2017

Member

I think I'm done with the arpeggiator now for 1.2 . I reverted one of the changes but the rest is fine to go and also took the liberty of bumping the default arp time from 100ms to 200ms. half the speed that is. Else it will just fire away and scare our beloved beginners. The fixes here basically takes care of regressions from 1.1.3.

I'll merge this in a day if there is no objection.

Member

zonkmachine commented Oct 8, 2017

I think I'm done with the arpeggiator now for 1.2 . I reverted one of the changes but the rest is fine to go and also took the liberty of bumping the default arp time from 100ms to 200ms. half the speed that is. Else it will just fire away and scare our beloved beginners. The fixes here basically takes care of regressions from 1.1.3.

I'll merge this in a day if there is no objection.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Oct 9, 2017

Member

Two of the fixes didn't pass testing and had to be reverted. I'll open a new ticket (meta) for the remaining issues once this PR is merged.
Edit: #3880

Member

zonkmachine commented Oct 9, 2017

Two of the fixes didn't pass testing and had to be reverted. I'll open a new ticket (meta) for the remaining issues once this PR is merged.
Edit: #3880

Arpeggiator fixes
Set 'master note' for silent notes on sort mode.
Prevent silent notes to play as ordinary notes in the background
when they are waiting for their turn to arpeggiate.

Remove unnecessary test (it will always return TRUE).

Slower default speed (200ms).

@zonkmachine zonkmachine merged commit 6da8737 into LMMS:stable-1.2 Oct 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zonkmachine zonkmachine deleted the zonkmachine:arpnotedecay branch Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment