Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arpeggio sort mode #3867

Merged
merged 1 commit into from
Oct 10, 2017
Merged

Fix arpeggio sort mode #3867

merged 1 commit into from
Oct 10, 2017

Conversation

zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Oct 10, 2017 •
edited
Loading

When in sort mode and playing over multiple base notes, in the
beginning of the notes there is a chance that the notes will play
together as an ordinary chord instead of arpeggiate.
This is a regression from 6650dd3.

The fix reimplements this part that was dropped.

Fixes #3342

@zonkmachine
Fix arpeggio sort mode
c49ee0c 
When in sort mode and playing over multiple base notes, in the
beginning of the notes there is a chance that the notes will play
together as an ordinary chord instead of arpeggiate.
This is a regression from 6650dd3.

Fixes LMMS#3342
@zonkmachine zonkmachine merged commit 2d583db into LMMS:stable-1.2 Oct 10, 2017
@zonkmachine zonkmachine mentioned this pull request Oct 10, 2017
Closed
@zonkmachine zonkmachine deleted the arpeggiosortmode branch October 10, 2017 04:48
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
@zonkmachine
Fix arpeggio sort mode (LMMS#3867)
612bffb 
When in sort mode and playing over multiple base notes, in the
beginning of the notes there is a chance that the notes will play
together as an ordinary chord instead of arpeggiate.
This is a regression from 6650dd3.

Fixes LMMS#3342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tab FUNC / New arpeggio : several issues
1 participant
@zonkmachine