New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sfxr buffer noise #3883

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
2 participants
@PhysSong
Member

PhysSong commented Oct 15, 2017

Fixes #3383 by zeroing buffer out. Actually I don't exactly know why it works...

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Oct 15, 2017

Member

Actually I don't exactly know why it works...

It doesn't. The bug is apparently intermittent. It takes some tweaking. In the test project in #3383 you can turn down the decay on sfxr (on sfxr, not the general pluggin). That triggered it for me.

Member

zonkmachine commented Oct 15, 2017

Actually I don't exactly know why it works...

It doesn't. The bug is apparently intermittent. It takes some tweaking. In the test project in #3383 you can turn down the decay on sfxr (on sfxr, not the general pluggin). That triggered it for me.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Oct 15, 2017

Member

I tested this wrong. Sorry, redoing it!

Member

zonkmachine commented Oct 15, 2017

I tested this wrong. Sorry, redoing it!

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Oct 15, 2017

Member

Tested it again properly. The fix of course works. 🚜
I think you can go ahead and just merge it.

Member

zonkmachine commented Oct 15, 2017

Tested it again properly. The fix of course works. 🚜
I think you can go ahead and just merge it.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Oct 16, 2017

Member

Actually I don't exactly know why it works...

It's the same noise and the same solution as for the buffer noise in sfxr and it works fine. All I need to know ;) .

Member

zonkmachine commented Oct 16, 2017

Actually I don't exactly know why it works...

It's the same noise and the same solution as for the buffer noise in sfxr and it works fine. All I need to know ;) .

@zonkmachine zonkmachine merged commit eaa7b0d into LMMS:stable-1.2 Oct 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

lukas-w added a commit that referenced this pull request Oct 17, 2017

PlayHandle: Zero out buffer before processing
Fixes buffer noises when instruments don't write the whole buffer, such as
bitinvader. Related:
* #3884 (comment): #3884 (comment)
* #3883
# #3383

@PhysSong PhysSong deleted the PhysSong:sfxrbuf branch Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment