Fix sfxr buffer noise - #3883
Merged
Merged
Conversation
Contributor
|
Contributor
|
I tested this wrong. Sorry, redoing it! |
Contributor
|
Tested it again properly. The fix of course works. 🚜 |
Contributor
It's the same noise and the same solution as for the buffer noise in sfxr and it works fine. All I need to know ;) . |
lukas-w
added a commit
that referenced
this pull request
Oct 17, 2017
Fixes buffer noises when instruments don't write the whole buffer, such as bitinvader. Related: * #3884 (comment): #3884 (comment) * #3883 # #3383
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Fixes buffer noises when instruments don't write the whole buffer, such as bitinvader. Related: * LMMS#3884 (comment): LMMS#3884 (comment) * LMMS#3883 # LMMS#3383
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3383 by zeroing buffer out. Actually I don't exactly know why it works...