Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix destructor call in NotePlayHandleManager #3884
Fixes a regression from #3783 due to missing destructor call. It should have been added in 42e67d2, but not.
Oct 16, 2017
1 check passed
added a commit
this pull request
Oct 17, 2017
It's definitely an improvement. There is no longer a thunderclap coming out of the reverb. I still get a NaN and the noise cuts out though when moving the tempo slider while looping.
I ran it with the fpe debug and got the backtrace below. It reminds me of a comment here which also had a problem file with a bitinvader in it.