Skip to content

Use weak loading of libjack - #3887

Merged
tresf merged 1 commit into
LMMS:stable-1.2from
tresf:weakjack
Oct 16, 2017
Merged

Use weak loading of libjack#3887
tresf merged 1 commit into
LMMS:stable-1.2from
tresf:weakjack

Conversation

@tresf

@tresf tresf commented Oct 16, 2017

Copy link
Copy Markdown
Member

WeakJack is a third party tool that abstracts the JACK Application Binary Interface for use with various jack versions. It helps make LMMS a portable application on Linux.

  • This used to be part of Add AppImage support to Linux builds #3688. It was separated to make tracking (blaming, cherry-picking, submoduling) easier.
  • This is 100% 3rd-party code and should eventually be submoduled.

@tresf

tresf commented Oct 16, 2017

Copy link
Copy Markdown
Member Author

Travis-CI passes for Linux and Windows. I'm not waiting for Apple, this has been tested several times in the other PR. Merging.

@tresf
tresf merged commit c051e9b into LMMS:stable-1.2 Oct 16, 2017
@tresf
tresf deleted the weakjack branch October 16, 2017 18:46
@lukas-w

lukas-w commented Oct 16, 2017

Copy link
Copy Markdown
Member

Can we move the third-party code to a dedicated directory, such as src/3rdparty, similar to what I've done in #3873 or #3475? This will make it clear to everyone that it's not part of LMMS, and we can easily exclude it from tools like automatic code formatting.

Also, maybe we should add a file or a comment somewhere that documents the upstream source of the code.

@tresf

tresf commented Oct 16, 2017

Copy link
Copy Markdown
Member Author

@lukas-w I agree fundamentally, although I see little benefit in doing refactoring in stable-1.2 branch. We could triage these refactoring items into a new milestone so that we don't forget them? ArashPartow/exprtk is another candidate.

@lukas-w

lukas-w commented Oct 16, 2017

Copy link
Copy Markdown
Member

Sure 👍

@tresf tresf mentioned this pull request Oct 16, 2017
16 tasks
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants