Use weak loading of libjack - #3887
Merged
Merged
Conversation
Member
Author
|
Travis-CI passes for Linux and Windows. I'm not waiting for Apple, this has been tested several times in the other PR. Merging. |
Member
|
Can we move the third-party code to a dedicated directory, such as Also, maybe we should add a file or a comment somewhere that documents the upstream source of the code. |
Member
Author
|
@lukas-w I agree fundamentally, although I see little benefit in doing refactoring in |
Member
|
Sure 👍 |
16 tasks
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WeakJack is a third party tool that abstracts the JACK Application Binary Interface for use with various jack versions. It helps make LMMS a portable application on Linux.