New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use weak loading of libjack #3887

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
2 participants
@tresf
Member

tresf commented Oct 16, 2017

WeakJack is a third party tool that abstracts the JACK Application Binary Interface for use with various jack versions. It helps make LMMS a portable application on Linux.

  • This used to be part of #3688. It was separated to make tracking (blaming, cherry-picking, submoduling) easier.
  • This is 100% 3rd-party code and should eventually be submoduled.
@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Oct 16, 2017

Member

Travis-CI passes for Linux and Windows. I'm not waiting for Apple, this has been tested several times in the other PR. Merging.

Member

tresf commented Oct 16, 2017

Travis-CI passes for Linux and Windows. I'm not waiting for Apple, this has been tested several times in the other PR. Merging.

@tresf tresf merged commit c051e9b into LMMS:stable-1.2 Oct 16, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@tresf tresf deleted the tresf:weakjack branch Oct 16, 2017

@lukas-w

This comment has been minimized.

Show comment
Hide comment
@lukas-w

lukas-w Oct 16, 2017

Member

Can we move the third-party code to a dedicated directory, such as src/3rdparty, similar to what I've done in #3873 or #3475? This will make it clear to everyone that it's not part of LMMS, and we can easily exclude it from tools like automatic code formatting.

Also, maybe we should add a file or a comment somewhere that documents the upstream source of the code.

Member

lukas-w commented Oct 16, 2017

Can we move the third-party code to a dedicated directory, such as src/3rdparty, similar to what I've done in #3873 or #3475? This will make it clear to everyone that it's not part of LMMS, and we can easily exclude it from tools like automatic code formatting.

Also, maybe we should add a file or a comment somewhere that documents the upstream source of the code.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Oct 16, 2017

Member

@lukas-w I agree fundamentally, although I see little benefit in doing refactoring in stable-1.2 branch. We could triage these refactoring items into a new milestone so that we don't forget them? ArashPartow/exprtk is another candidate.

Member

tresf commented Oct 16, 2017

@lukas-w I agree fundamentally, although I see little benefit in doing refactoring in stable-1.2 branch. We could triage these refactoring items into a new milestone so that we don't forget them? ArashPartow/exprtk is another candidate.

@lukas-w

This comment has been minimized.

Show comment
Hide comment
@lukas-w

lukas-w Oct 16, 2017

Member

Sure 👍

Member

lukas-w commented Oct 16, 2017

Sure 👍

@tresf tresf referenced this pull request Oct 16, 2017

Merged

Add AppImage support to Linux builds #3688

16 of 16 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment