New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable portaudio on Windows #3889

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Projects
3 participants
@Umcaruje
Member

Umcaruje commented Oct 16, 2017

#512 Has been happening for more and more users lately, we have people who can't even open the software on their machines. I provided them with a build with portaudio removed and their issues were gone.

Portaudio was always hard to set up on windows for me, and I find SDL works every time. If WASAPI support is required, I think we should focus on libsoundio, even though that would mean dropping support for windows XP. ASIO is also a planned feature for libsoundio: andrewrk/libsoundio#23

Anyways, in conclusion, Portaudio causes more problems than benfits on windows, and I think it should be disabled.

@Umcaruje Umcaruje added this to the 1.2.0 milestone Oct 16, 2017

@Umcaruje

This comment has been minimized.

Show comment
Hide comment
@Umcaruje

Umcaruje Oct 17, 2017

Member

Unless there are objections, I'll merge this in 24 hours.

Member

Umcaruje commented Oct 17, 2017

Unless there are objections, I'll merge this in 24 hours.

@lukas-w

This comment has been minimized.

Show comment
Hide comment
@lukas-w

lukas-w Oct 18, 2017

Member

It's easy enough to revert in case there are any objections. 👍

Member

lukas-w commented Oct 18, 2017

It's easy enough to revert in case there are any objections. 👍

@lukas-w lukas-w merged commit 4594e7e into LMMS:stable-1.2 Oct 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
SET(WANT_SOUNDIO OFF)
SET(WANT_WINMM ON)
SET(LMMS_HAVE_WINMM TRUE)
SET(STATUS_ALSA "<not supported on this platform>")
SET(STATUS_JACK "<not supported on this platform>")
SET(STATUS_PULSEAUDIO "<not supported on this platform>")
SET(STATUS_PORTAUDIO "<disabled on this platform")

This comment has been minimized.

@PhysSong

PhysSong Oct 18, 2017

Member

Missing > here.

@PhysSong

PhysSong Oct 18, 2017

Member

Missing > here.

This comment has been minimized.

@lukas-w
@lukas-w

lukas-w Oct 18, 2017

Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment