New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZynAddSubFx: Fix preset loading #3891

Merged
merged 1 commit into from Oct 17, 2017

Conversation

Projects
None yet
2 participants
@lukas-w
Member

lukas-w commented Oct 17, 2017

@tresf I can't reproduce the "Zyn exports as sine-wave" part from #3886. Does this change fix that issue as well?

Here's an AppImage for testing: https://transfer.sh/12r7NT/lmms-1.2.0-rc4.12-linux-x86_64.AppImage.zip

Fixes #3886, a regression from #1719

ZynAddSubFx: Fix preset loading
Fix regression from #1719
Fixes #3886
@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Oct 17, 2017

Member

Tested, works.

Member

tresf commented Oct 17, 2017

Tested, works.

@tresf tresf self-requested a review Oct 17, 2017

@tresf

tresf approved these changes Oct 17, 2017

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Oct 17, 2017

Member

Once again, cancelling Apple and not waiting. Merging. Thanks @lukas-w!

Member

tresf commented Oct 17, 2017

Once again, cancelling Apple and not waiting. Merging. Thanks @lukas-w!

@tresf tresf merged commit 9d560a3 into stable-1.2 Oct 17, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@lukas-w lukas-w deleted the fix/zyn-banks branch Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment