New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Automation Point delete radius and size #3902

Merged
merged 2 commits into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@zonkmachine
Member

zonkmachine commented Oct 22, 2017

Exchange defective algorithm for Automatin Point delete radius with a new function adapted from AutomationEditor::drawLine(),
Increase minimal Automation Point radius by 50%.

The sensitivity for grabbing/moving an Automation Point is still a bit off on the fines quantization levels.

Fixes #3896

@zonkmachine zonkmachine requested a review from Umcaruje Oct 22, 2017

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Oct 22, 2017

Member

I found a much better way by adapting AutomationEditor::drawLine().

Member

zonkmachine commented Oct 22, 2017

I found a much better way by adapting AutomationEditor::drawLine().

}
removePoints( m_drawLastTick, pos_ticks );
Engine::getSong()->setModified();

This comment has been minimized.

@PhysSong

PhysSong Oct 22, 2017

Member

It will mark the project as modified if no points are removed. It should be moved into removePoints().

@PhysSong

PhysSong Oct 22, 2017

Member

It will mark the project as modified if no points are removed. It should be moved into removePoints().

This comment has been minimized.

@zonkmachine

zonkmachine Oct 22, 2017

Member

I remove points without checking if there are any there. So if I add bool pointsRemoved = false; and lets the delete loop set it to true, it is still going to set the project to changed as soon as the mouse moves just a bit without really removing anything.

@zonkmachine

zonkmachine Oct 22, 2017

Member

I remove points without checking if there are any there. So if I add bool pointsRemoved = false; and lets the delete loop set it to true, it is still going to set the project to changed as soon as the mouse moves just a bit without really removing anything.

This comment has been minimized.

@zonkmachine

zonkmachine Oct 22, 2017

Member

The behaviour right now is, deleting points with right click sets the project to changed but deleting by dragging over points doesn't.

@zonkmachine

zonkmachine Oct 22, 2017

Member

The behaviour right now is, deleting points with right click sets the project to changed but deleting by dragging over points doesn't.

This comment has been minimized.

@zonkmachine

zonkmachine Oct 23, 2017

Member

@PhysSong I don't know quite how to move Engine::getSong()->setModified(); to removePoints(). This is already an improvement from before when setModified() wasn't called at all. I suggest merging this 'as is', or I can have another look at it if someone can point me in the right direction but for now I think it's low priority.

@zonkmachine

zonkmachine Oct 23, 2017

Member

@PhysSong I don't know quite how to move Engine::getSong()->setModified(); to removePoints(). This is already an improvement from before when setModified() wasn't called at all. I suggest merging this 'as is', or I can have another look at it if someone can point me in the right direction but for now I think it's low priority.

This comment has been minimized.

@PhysSong

PhysSong Oct 23, 2017

Member

Engine::getSong()->setModified(); is an UX problem. So I think it's out of scope a little bit. Since the point of this PR is on GUI part, merging as-is looks fine. Dropping that will be fine, too.
I can create a PR which fixes the UX issue later. I think it will be the best way. 👍

@PhysSong

PhysSong Oct 23, 2017

Member

Engine::getSong()->setModified(); is an UX problem. So I think it's out of scope a little bit. Since the point of this PR is on GUI part, merging as-is looks fine. Dropping that will be fine, too.
I can create a PR which fixes the UX issue later. I think it will be the best way. 👍

This comment has been minimized.

@zonkmachine

zonkmachine Oct 23, 2017

Member

All right. I'll merge this tomorrow.

@zonkmachine

zonkmachine Oct 23, 2017

Member

All right. I'll merge this tomorrow.

@zonkmachine zonkmachine merged commit f9ab2de into LMMS:stable-1.2 Oct 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zonkmachine zonkmachine deleted the zonkmachine:automationpointissues branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment