Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preset preview issues with peak controller(s) #3904

Merged
merged 1 commit into from Apr 4, 2018

Conversation

PhysSong
Copy link
Member

Fixes #3897.
This PR ensures peak controller effects from preview track don't instantiate a peak controller and replaces itself to a dummy effect by setting m_okay to false.
Here's a preset for test: PeakController.xpf.zip

@PhysSong
Copy link
Member Author

The difference between this and @gi0e5b06's approach is: this don't create peak controller while @gi0e5b06's fix create it and not add to the song. I'll compare two ways and find better way...

@gi0e5b06
Copy link

@PhysSong If you don't create the peak controller(s), the preset may sound totally different. Which just brings this other issue #3906 . OTOH, the consequences of creating these temporary controllers are still unknown but I didn't notice anything strange so far (after fixing some double-ckick bugs in the file browser).

@PhysSong
Copy link
Member Author

PhysSong commented Oct 23, 2017

@gi0e5b06 That is a long-standing issue. However, your suggestion doesn't look harmful for me. I 'll look into this more. 😄

@PhysSong
Copy link
Member Author

PhysSong commented Apr 2, 2018

Partially switched to @gi0e5b06's approach. Waiting for tests...

@zonkmachine
Copy link
Member

Tests fine. Issue fixed with this PR.

@PhysSong PhysSong merged commit 00f9590 into LMMS:stable-1.2 Apr 4, 2018
@PhysSong PhysSong deleted the peakcontrollerpreview branch April 4, 2018 00:07
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants