New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LADSPA - Fix various floating point errors #3927

Merged
merged 3 commits into from Oct 31, 2017

Conversation

Projects
None yet
2 participants
@zonkmachine
Member

zonkmachine commented Oct 30, 2017

Fixes NaN in project from closed issue #3685
Also, some fixes salvaged from #3313

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Oct 30, 2017

Member

@zonkmachine thanks! Just a reminder that once merged, we should PR against https://github.com/swh/ladspa with the same fixes.

Member

tresf commented Oct 30, 2017

@zonkmachine thanks! Just a reminder that once merged, we should PR against https://github.com/swh/ladspa with the same fixes.

@zonkmachine

This comment has been minimized.

Show comment
Hide comment
@zonkmachine

zonkmachine Oct 30, 2017

Member

Last fixes. Adapted coding style to the rest of the file and swapped fmaxf() with std::max().
I'll merge this later. It's basically just one-liners and well tested.

Just a reminder that once merged, we should PR against https://github.com/swh/ladspa with the same fixes.

I'll try and build those pluggins first. Last time I looked at it I failed miserably.

Member

zonkmachine commented Oct 30, 2017

Last fixes. Adapted coding style to the rest of the file and swapped fmaxf() with std::max().
I'll merge this later. It's basically just one-liners and well tested.

Just a reminder that once merged, we should PR against https://github.com/swh/ladspa with the same fixes.

I'll try and build those pluggins first. Last time I looked at it I failed miserably.

@zonkmachine zonkmachine merged commit 88b940f into LMMS:stable-1.2 Oct 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zonkmachine zonkmachine deleted the zonkmachine:ladspafixes branch Oct 31, 2017

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Nov 3, 2017

Member

I'll try and build those pluggins first. Last time I looked at it I failed miserably.

This should ease your struggles: swh/ladspa#55

Besides the Travis-CI capabilities, it fixes a few compilation problems I ran into while working on #3931. They haven't been merged yet so they're sitting as duplicates in the Travis-CI PR.

Pay close attention to the apt-get ... commands in travis.yml, it has the dependencies you'll need incase you don't already have them on your system.

Lastly, make install prefix=$HOME/foo is important if you don't want to run the install as root and avoid the default /usr/lib/[ladspa] prefix.

Member

tresf commented Nov 3, 2017

I'll try and build those pluggins first. Last time I looked at it I failed miserably.

This should ease your struggles: swh/ladspa#55

Besides the Travis-CI capabilities, it fixes a few compilation problems I ran into while working on #3931. They haven't been merged yet so they're sitting as duplicates in the Travis-CI PR.

Pay close attention to the apt-get ... commands in travis.yml, it has the dependencies you'll need incase you don't already have them on your system.

Lastly, make install prefix=$HOME/foo is important if you don't want to run the install as root and avoid the default /usr/lib/[ladspa] prefix.

@tresf

This comment has been minimized.

Show comment
Hide comment
@tresf

tresf Nov 8, 2017

Member

PR submitted swh/ladspa#57. Second set of eyes appreciated.

Member

tresf commented Nov 8, 2017

PR submitted swh/ladspa#57. Second set of eyes appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment