New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linearToLogScale() - Input validation #3932

Merged
merged 1 commit into from Nov 3, 2017

Conversation

Projects
None yet
1 participant
@zonkmachine
Member

zonkmachine commented Nov 3, 2017

linearToLogScale() seem to be called only in AutomatableModel::inverseScaledValue() and I don't know what possible issues could come from this. Binding the input value to the max/min values seem like the way to go and pleases the fpe check.

Crash with fpe debug option when opening an LADSPA gui.

Program received signal SIGFPE, Arithmetic exception.
0x00007ffff459893f in __ieee754_powf (x=x@entry=-0,00100100099, y=y@entry=0,36787945) at ../sysdeps/ieee754/flt-32/e_powf.c:125
125	../sysdeps/ieee754/flt-32/e_powf.c: No such file or directory.
(gdb) bt full
#0  0x00007ffff459893f in __ieee754_powf (x=x@entry=-0,00100100099, y=y@entry=0,36787945) at ../sysdeps/ieee754/flt-32/e_powf.c:125
        z = <optimized out>
        ax = <optimized out>
...
        iy = 1052531378
        is = <optimized out>
#1  0x00007ffff459d1db in __powf (x=-0,00100100099, y=0,36787945) at w_powf.c:27
        z = <optimized out>
#2  0x00000000004f0954 in linearToLogScale (min=1, max=1000, value=0) at /home/zonkmachine/builds/lmms/lmms/include/lmms_math.h:222
        EXP = 0,36787945
        val = -0,00100100099
        result = 0
#3  0x00000000004f19cb in AutomatableModel::inverseScaledValue (this=0x1924cc0, value=0)
    at /home/zonkmachine/builds/lmms/lmms/src/core/AutomatableModel.cpp:271
No locals.

@zonkmachine zonkmachine requested a review from PhysSong Nov 3, 2017

@zonkmachine zonkmachine merged commit 0c31cf4 into LMMS:stable-1.2 Nov 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zonkmachine zonkmachine deleted the zonkmachine:lintologinputvalidation branch Nov 3, 2017

@PhysSong PhysSong removed their request for review Nov 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment