New attempt at fetching submodules#3957
Conversation
| if (INCLUDE_DIRS) | ||
| TARGET_INCLUDE_DIRECTORIES(lmmsobjs PRIVATE ${INCLUDE_DIRS}) | ||
| ENDIF() | ||
| IF(TARGET ${LIB}) |
There was a problem hiding this comment.
I already did this in 0dbdafc (albeit with inconsistent indentation...), it just hasn't been merged back to master yet.
There was a problem hiding this comment.
Thanks. I think I'll keep it here and we can deal with the minor merge conflict when rebasing.
|
It's been 8 days without any testing feedback, but in that time, we've merged quite a bit of submodules making this needed more and more each day. Calf, for example, is huge and the only way I've found to reduce that size is to reduce the size of the database using the I'm merging this to master, but there's a good chance it will need modifications and if we cherry-pick it to stable, we'll need to be cognizant of syncing them. |
The new technique parses the
.gitmodulesfile and clones each submodule by path, unless the module was specified inSKIP_SUBMODULES.To test, just clone this branch without the
--recursiveoption and try to run cmake.Advanced usage:
Or via CLI:
Most of the time, users shouldn't even know this module exists. It'll just be part of the codebase to improve productivity by reducing the number of build and configure errors directly related to submodule cloning.
ADD_SUBDIRECTORY(...)to be cognizant of the submodule status, but that is out of scope for this PR.Once tested and merged to
master, this PR should be safe to cherry-pick back tostable-1.2.