/ lmms Public
New attempt at fetching submodules #3957
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
The new technique parses the
.gitmodulesfile and clones each submodule by path, unless the module was specified in
To test, just clone this branch without the
--recursiveoption and try to run cmake.
Or via CLI:
Most of the time, users shouldn't even know this module exists. It'll just be part of the codebase to improve productivity by reducing the number of build and configure errors directly related to submodule cloning.
ADD_SUBDIRECTORY(...)to be cognizant of the submodule status, but that is out of scope for this PR.
Once tested and merged to
master, this PR should be safe to cherry-pick back to