Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch opl2 to submodule #3962

Merged
merged 2 commits into from Nov 10, 2017
Merged

Switch opl2 to submodule #3962

merged 2 commits into from Nov 10, 2017

Conversation

tresf
Copy link
Member

@tresf tresf commented Nov 10, 2017

Switch the "OpulenZ" (opl2) instrument plugin to pull directly from https://github.com/adplug/adplug.

There are some commits that have been added to the codebase that never made it upstream however upstream has been maintained as well, so some of them are redundant to apply.

One of my concerns is C++11 compatibility, specifically the use of the __inline combined with Clang, which caused problems in the past. Edit:, upstream removed __inline, may be OK.

Here's a full history of our (downstream) changes to the fmopl.c library. These will help resolve issues that occur as a result of this merge.
https://github.com/LMMS/lmms/commits/stable-1.2/plugins/opl2/fmopl.c

Tasks

  • Switch opl2 to use subdirectory
  • Rename plugin directory to "OpulenZ" to match convention, write upgrade task.
  • Handle edge-case compilation issues

@softrabbit FYI.

@tresf tresf mentioned this pull request Nov 10, 2017
@tresf
Copy link
Member Author

tresf commented Nov 10, 2017

There doesn't appear to be any issues with the build, even on Apple. Merging.

@tresf tresf merged commit 289887f into LMMS:master Nov 10, 2017
@tresf tresf deleted the opl2 branch November 10, 2017 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant