New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch weakjack to submodule #3970
Conversation
@@ -67,6 +67,13 @@ ELSEIF(NOT ("${SDL_INCLUDE_DIR}" STREQUAL "")) | |||
INCLUDE_DIRECTORIES("${SDL_INCLUDE_DIR}") | |||
ENDIF() | |||
|
|||
IF(LMMS_HAVE_WEAKJACK) | |||
LIST(APPEND LMMS_SRCS "${WEAKJACK_INCLUDE_DIRS}/weak_libjack.c") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukas-w I wasn't really to sure where the best place for these were, so I placed them here. A second set of eyes is appreciated, but I think it's ready to merge.
weakjack submodule doesn't have any files matches any globs in: lmms/cmake/modules/CheckSubmodules.cmake Line 21 in 5e2c105
|
Switches weakjack to submodule.
Testers needed!
The AppImage (specifically,
linuxdeployqt
) was segfaulting while I was trying to test this, but it also was happening on current master, so it may be an issue with my build system.To create an AppImage:
make install && make appimage
Note, this will cause a merge conflict with syncs from
stable-1.2
due to d4d909c.