Skip to content

Unsolo mixer channels on delete - #3982

Merged
zonkmachine merged 1 commit into
LMMS:stable-1.2from
zonkmachine:unsolobeforedelete
Nov 21, 2017
Merged

zonkmachine merged 1 commit into
LMMS:stable-1.2from
zonkmachine:unsolobeforedelete

Conversation

@zonkmachine

Copy link
Copy Markdown
Contributor

If you remove a channel in the Fx-Mixer while it's soloed, the other channels are left muted. Clear channels before deleting and the remaining channels are restored to their pre-solo values.

@zonkmachine zonkmachine mentioned this pull request Nov 18, 2017
@zonkmachine

Copy link
Copy Markdown
Contributor Author

I've seen no new issues from this PR. I suggest merging this and keeping an eye on #3983. It would be good if someone commented the code and also on the backtrace in #3983.

@zonkmachine

Copy link
Copy Markdown
Contributor Author

I suggest merging this and keeping an eye on #3983.

That's a separate issue. I've tested this with the proposed fix in #3983 and they play well together.
Merge?

@zonkmachine
zonkmachine merged commit 55076d0 into LMMS:stable-1.2 Nov 21, 2017
@zonkmachine
zonkmachine deleted the unsolobeforedelete branch November 24, 2017 07:44
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
If a mixer channel is soloed when it's deleted the other channels are left in the
state their in which is, for the most part, muted. Solve this by clearing mixer
channels on delete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant