Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsolo mixer channels on delete #3982

Merged
merged 1 commit into from Nov 21, 2017

Conversation

@zonkmachine
Copy link
Member

@zonkmachine zonkmachine commented Nov 18, 2017

If you remove a channel in the Fx-Mixer while it's soloed, the other channels are left muted. Clear channels before deleting and the remaining channels are restored to their pre-solo values.

@zonkmachine zonkmachine mentioned this pull request Nov 18, 2017
@zonkmachine
Copy link
Member Author

@zonkmachine zonkmachine commented Nov 19, 2017

I've seen no new issues from this PR. I suggest merging this and keeping an eye on #3983. It would be good if someone commented the code and also on the backtrace in #3983.

@zonkmachine
Copy link
Member Author

@zonkmachine zonkmachine commented Nov 20, 2017

I suggest merging this and keeping an eye on #3983.

That's a separate issue. I've tested this with the proposed fix in #3983 and they play well together.
Merge?

@zonkmachine zonkmachine merged commit 55076d0 into LMMS:stable-1.2 Nov 21, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zonkmachine zonkmachine deleted the zonkmachine:unsolobeforedelete branch Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.