New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various bugs when using JACK #4005

Merged
merged 3 commits into from Dec 3, 2017

Conversation

Projects
1 participant
@PhysSong
Member

PhysSong commented Nov 23, 2017

Change the way AudioJack handles processing stop. Fixes #3397, fixes #3396, fixes #3207.

Fix JACK crashes and freezings
Change the way AudioJack handles processing stop

@PhysSong PhysSong changed the title from Fix JACK crashes and freezings to Fix crashes and freezings when using JACK Nov 24, 2017

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Nov 24, 2017

Member

@PaulBatchelor Could you test this and let me know if the bug is fixed?

Member

PhysSong commented Nov 24, 2017

@PaulBatchelor Could you test this and let me know if the bug is fixed?

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Nov 26, 2017

Member

I confirmed this fixes #3396(JACK part of #2845, too) just now. I guess this will fix #2934, too. @Umcaruje Can you test this?

Edit: Partial fix for #2934 is confirmed.

Member

PhysSong commented Nov 26, 2017

I confirmed this fixes #3396(JACK part of #2845, too) just now. I guess this will fix #2934, too. @Umcaruje Can you test this?

Edit: Partial fix for #2934 is confirmed.

@PhysSong PhysSong changed the title from Fix crashes and freezings when using JACK to Fix various bugs when using JACK Nov 26, 2017

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Nov 28, 2017

Member

I'm afraid it's not thread safe. SDL provides SDL_LockAudio function for thread-safety, but I can't find proper JACK equivalent. Maybe adding a custom lock is the best way?

Edit: added a mutex via 3f22073.

Member

PhysSong commented Nov 28, 2017

I'm afraid it's not thread safe. SDL provides SDL_LockAudio function for thread-safety, but I can't find proper JACK equivalent. Maybe adding a custom lock is the best way?

Edit: added a mutex via 3f22073.

@PhysSong PhysSong added this to In Progress in Release LMMS 1.2.0-RC5 Nov 28, 2017

@PhysSong

This comment has been minimized.

Show comment
Hide comment
@PhysSong

PhysSong Dec 1, 2017

Member

Is it okay to merge this?

Member

PhysSong commented Dec 1, 2017

Is it okay to merge this?

@PhysSong PhysSong merged commit dd4a73e into LMMS:stable-1.2 Dec 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PhysSong PhysSong deleted the PhysSong:jackbug branch Dec 3, 2017

@PhysSong PhysSong moved this from In Progress to Done in Release LMMS 1.2.0-RC5 Dec 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment