Fix song-editor regressions and BB-editor bugs introduced in #3487#4008
Conversation
Fix bugs introduced in LMMS#3487
| new StringPairDrag( QString( "tco_%1" ).arg( | ||
| m_tco->getTrack()->type() ), | ||
| dataFile.toString(), thumbnail, this ); | ||
| } |
There was a problem hiding this comment.
okay, but now you can't select/deselect a single TCO by [CTRL] + Click. That's why I moved this whole block into the mouseMoveEvent(). There we can test if the mouse moved 2 pixels since click(copy TCO) or not(toggleSelected). See: https://github.com/LMMS/lmms/pull/3988/files
There was a problem hiding this comment.
@BaraMGB Thanks! I'll look into that. Anyway, what's this?
https://github.com/LMMS/lmms/pull/3649/files#diff-cb2a453c979a4777b9330e2b96644f0eL707
| } | ||
| } | ||
| else if( !me->modifiers() ) | ||
| else |
There was a problem hiding this comment.
@BaraMGB Should this be else, or else if( !me->modifiers() )?
There was a problem hiding this comment.
The difference would be you can't move a tco with pressed shift and/or alt key. Perhaps else if(!me->modifier) is more discriptive.
There was a problem hiding this comment.
Okay. The latter is consistent with piano roll. Anyway, you changed it to the former in #3649. Was that intentional?
There was a problem hiding this comment.
No, I tried to make the code simpler. But now I think else if(! me->modifiers() is more discriptive. If someone wants to add a new modifier key, he/she can see where to add it in the code. Also I think, it's better to have a functionality only in a certain circumstance (no modifier key is pressed)
|
Sorry, next time I ask before I push to your branch. |
|
@BaraMGB It's okay. That's what I were going to changed, but I've accidentally undone the change before I commit. |
2 participants
Fix bugs introduced in #3487. Fixes some bugs in #3487, mostly reverting some changes in #3649.
Additional changes:
Supersedes #3988.