Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qt4 crash #4037

Merged
merged 3 commits into from Dec 6, 2017
Merged

Fix qt4 crash #4037

merged 3 commits into from Dec 6, 2017

Conversation

@BumblingCoder
Copy link
Contributor

@BumblingCoder BumblingCoder commented Dec 6, 2017

This fixes issue #4030. The problem is that we were loading a Qt5 library from a Qt4 application.

update
This code loads a Qt5 library, which will cause problems if done from a Qt4 application. If the application is Qt4 based we don't have a bug with kde changing the menus anyway, so we can skip this code.
@tresf tresf merged commit 45d6b29 into LMMS:stable-1.2 Dec 6, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.