Use "Set value" as title for QInputDialog of some widgets. - #4063
Conversation
These widgets are the Fader, Knob and LcdSpinBox.
|
This looks good. In regards to the way we're handling this, I feel we may be able to consolidate the redundant strings. @liushuyu any thoughts? |
|
|
I went ahead and merged this as per my point 1 above. I still plan to consolidate these - but when I took a first pass at it today it turned out there's some cleanup around ModelViews/Models required to make the consolidation work well, so it's going to have to happen incrementally. |
Use "Set value" as title for QInputDialog of some widgets.
These widgets are the Fader, Knob and LcdSpinBox.


The QInputDialog shows when a widget from the above is double-clicked.
I propose this change because the current title
windowTitle()usually doesn't have a specified value and defaults tolmms:With this change, it will always default to
Set value: