Move Zyn GUI to main thread#4065
Merged
Merged
Conversation
Member
|
As the author of this patch, I'd like to say that it should be fine on every platforms. The reasons are:
Anyway, testing is always good. 👍 |
Member
Author
|
Here's a build for testing this out: https://github.com/tresf/lmms/releases/download/v1.2.0-rc4/lmms-1.2.0-rc5.3-mac10.13.dmg |
Member
Author
|
We've extensively tested this on Mac, Linux and Windows. Here's some evidence that the Zyn UI can remain open and stable with this PR despite several preset changes. Worth noting... I was able to get it to crash twice, but I cannot reproduce now despite how hard I try. When it crashed, the stack trace did not point to the UX, so @PhysSong suspects I had found an existing edge case that already exists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #703
We'll need some solid testing on Windows and Linux to make sure no regressions are caused as a result of this change.