Fix command line rendering with VSTs #4093
Conversation
Just FYI - instead of |
@DomClark Fix conflicts and then merge? |
Done, although I've never done this before so let's hope I haven't messed anything up...
I'm happy, but has anyone else tested this? I'm often worried I'm not rigorous enough with these things, and don't currently have the time to test further. |
Agreed. I'll put a request out on Discord. |
Per request on Discord
|
Command-line rendering with VSTs works for me nicely with this PR. |
Here's some baseline VST testing kindly provided from JD on Discord. I asked the community to test out the build to make sure it did not introduce any regressions.
|
I'd say this is good to merge then. |
Fixes #3449.
Change summary:
vestigeInstrument
andVstEffectControls
intomanageVestigeInstrumentView
andmanageVSTEffectView
. There's still some more to go but this much fixes the problem.Window class registration in
RemoteVstPlugin
I've moved tomain()
- the class is also used for the message window that receives timer events and messages to be processed on the main thread, so it must be created regardless of whether a UI exists or not.